Skip to content

Fix siteName casing #33808

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jeremydvoss merged 2 commits into from
Jan 16, 2024
Merged

Fix siteName casing #33808

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3b957df
Fix siteName casing
jeremydvoss Jan 11, 2024
a4c45e2
changelog
jeremydvoss Jan 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions sdk/monitor/azure-monitor-opentelemetry/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,8 @@

- Implement distro detection for statsbeat feature
([#33761](https://github.com/Azure/azure-sdk-for-python/pull/33761))
- Fix siteName in diagnostic logging
([#33808](https://github.com/Azure/azure-sdk-for-python/pull/33808))

## 1.1.1 (2023-12-04)

Expand Down
2 changes: 1 addition & 1 deletion ...zure-monitor-opentelemetry/azure/monitor/opentelemetry/_diagnostics/diagnostic_logging.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ def _initialize(cls):
+ '"message":"%(message)s", '
+ '"properties":{'
+ '"operation":"Startup", '
+ f'"sitename":"{_SITE_NAME}", '
+ f'"siteName":"{_SITE_NAME}", '
+ f'"ikey":"{_get_customer_ikey_from_env_var()}", '
+ f'"extensionVersion":"{_EXTENSION_VERSION}", '
+ f'"sdkVersion":"{VERSION}", '
Expand Down
2 changes: 1 addition & 1 deletion sdk/monitor/azure-monitor-opentelemetry/tests/diagnostics/test_diagnostic_logging.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ def check_file_for_messages(file_path, level, messages):
assert json["message"] == message
properties = json["properties"]
assert properties["operation"] == "Startup"
assert properties["sitename"] == TEST_SITE_NAME
assert properties["siteName"] == TEST_SITE_NAME
assert properties["ikey"] == TEST_CUSTOMER_IKEY
assert properties["extensionVersion"] == TEST_EXTENSION_VERSION
assert properties["sdkVersion"] == TEST_VERSION
Expand Down
⚡