Skip to content

[WebPubSub] Update send methods signatures#34855

Merged
msyyc merged 6 commits intoAzure:mainfrom
xingsy97:update-sign
May 10, 2024
Merged

[WebPubSub] Update send methods signatures#34855
msyyc merged 6 commits intoAzure:mainfrom
xingsy97:update-sign

Conversation

@xingsy97
Copy link
Copy Markdown
Contributor

@xingsy97 xingsy97 commented Mar 20, 2024

Description

Diff with latest version (a beta version, 1.1.0b1)

  1. Add three override signatures for send* methods, application/json, text/plain, and application/octet-stream.
  2. Add union type to parameter content for send* methods
  3. Add groups parameter to get_client_access_token

Note: the next two items were already included in latest version 1.1.0b1, but will be shown in the diff with stable version 1.0.1

  1. Add new parameter filter for send* methods
  2. Add new methods remove_connection_from_all_groups

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@azure-sdk
Copy link
Copy Markdown
Collaborator

API change check

APIView has identified API level changes in this PR and created following API reviews.

azure-messaging-webpubsubservice

@xingsy97
Copy link
Copy Markdown
Contributor Author

Hi @msyyc , architect told me new API view is ok for him to approve. Please help merge this request.

@msyyc msyyc merged commit 78b00c5 into Azure:main May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants