[Cosmos] changes and sample for vector search control plane update#34882
Closed
simorenoh wants to merge 18 commits intoAzure:mainfrom
Closed
[Cosmos] changes and sample for vector search control plane update#34882simorenoh wants to merge 18 commits intoAzure:mainfrom
simorenoh wants to merge 18 commits intoAzure:mainfrom
Conversation
Collaborator
|
API change check APIView has identified API level changes in this PR and created following API reviews. |
simorenoh
requested review from
annatisch,
bambriz,
kushagraThapar and
xinlian12
as code owners
Pilchie
reviewed
Mar 28, 2024
aayush3011
reviewed
Mar 28, 2024
kushagraThapar
requested changes
Mar 29, 2024
Member
kushagraThapar
left a comment
kushagraThapar
left a comment
There was a problem hiding this comment.
Overall looks good to me, however, requesting changes on some documentation
annatisch
approved these changes
Apr 17, 2024
annatisch
reviewed
Apr 18, 2024
Member
Author
|
/azp run python - cosmos |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
Author
|
/azp run python - cosmos |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
Author
|
/azp run python - cosmos - ci |
|
Azure Pipelines successfully started running 1 pipeline(s). |
5 tasks
Member
Author
|
These changes were merged as part of #35468. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes for control-plane vector search bits, adding the vector embedding policy to container creation flow and the vector indexes to the existing indexing policy based on the doc shared and PRs done by the service team.
Samples and tests have been added as well.
Relevant updates just mean our indexing policy now has additional vector indexing fields:
And we now have the ability to pass in a new vector embedding policy json that looks like this:
I opted for leaving a raw dictionary/json for the new policy since it aligns with the already existing indexing policy, but if we feel we should change this do let me know.