Skip to content

Adding diagnostic log for distro + attach#34971

Merged
jeremydvoss merged 12 commits intoAzure:mainfrom
jeremydvoss:detect-attach
Apr 2, 2024
Merged

Adding diagnostic log for distro + attach#34971
jeremydvoss merged 12 commits intoAzure:mainfrom
jeremydvoss:detect-attach

Conversation

@jeremydvoss
Copy link
Copy Markdown
Member

@jeremydvoss jeremydvoss commented Mar 27, 2024

Description

As a prereq before attach backoff, adding a diagnostic log for when distro detects RP attach.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@github-actions github-actions Bot added the Monitor - Distro Monitor OpenTelemetry Distro label Mar 27, 2024
@azure-sdk
Copy link
Copy Markdown
Collaborator

azure-sdk commented Mar 27, 2024

API change check

API changes are not detected in this pull request.

@jeremydvoss jeremydvoss marked this pull request as ready for review March 29, 2024 20:48
@jeremydvoss jeremydvoss requested a review from lzchen as a code owner March 29, 2024 20:48
lzchen
lzchen reviewed Mar 29, 2024
View reviewed changes
Comment thread sdk/monitor/azure-monitor-opentelemetry/azure/monitor/opentelemetry/_constants.py Outdated
lzchen
lzchen reviewed Mar 29, 2024
View reviewed changes
Comment thread sdk/monitor/azure-monitor-opentelemetry/azure/monitor/opentelemetry/_configure.py Outdated
lzchen
lzchen reviewed Apr 1, 2024
View reviewed changes
Comment thread sdk/monitor/azure-monitor-opentelemetry/tests/test_constants.py Outdated
lzchen
lzchen reviewed Apr 1, 2024
View reviewed changes
Comment thread sdk/monitor/azure-monitor-opentelemetry/tests/test_constants.py Outdated
lzchen
lzchen approved these changes Apr 1, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@lzchen lzchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix tests.

@jeremydvoss jeremydvoss enabled auto-merge (squash) April 1, 2024 23:15
@jeremydvoss jeremydvoss merged commit 394dc9a into Azure:main Apr 2, 2024
@jeremydvoss jeremydvoss mentioned this pull request Apr 4, 2024
Merged
6 tasks
@summahto summahto mentioned this pull request Oct 29, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lzchen lzchen lzchen approved these changes

@lmazuel lmazuel Awaiting requested review from lmazuel

@hectorhdzg hectorhdzg Awaiting requested review from hectorhdzg hectorhdzg is a code owner

Assignees

No one assigned

Labels

Monitor - Distro Monitor OpenTelemetry Distro

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jeremydvoss @azure-sdk @lzchen
⚡