Skip to content

Fixed pyright error for MsalCredential #35415

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
xiangyan99 merged 5 commits into from
Apr 30, 2024
Merged

Fixed pyright error for MsalCredential #35415

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
3dd1f2f
Fixed pyright error for `MsalCredential`
xiangyan99 Apr 29, 2024
cf49a29
update
xiangyan99 Apr 29, 2024
9a9702d
updates
xiangyan99 Apr 29, 2024
d3572e4
Update sdk/identity/azure-identity/CHANGELOG.md
xiangyan99 Apr 30, 2024
2113afa
Update sdk/identity/azure-identity/azure/identity/_internal/msal_cred…
xiangyan99 Apr 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions sdk/identity/azure-identity/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,8 @@

### Bugs Fixed

- Fixed pyright error for `MsalCredential` ([#35184](https://github.com/Azure/azure-sdk-for-python/pull/35184))
Comment thread
xiangyan99 marked this conversation as resolved.
Outdated

### Other Changes

## 1.16.0 (2024-04-09)
Expand Down
3 changes: 2 additions & 1 deletion sdk/identity/azure-identity/azure/identity/_internal/msal_credentials.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
# ------------------------------------
import os
from typing import Any, List, Union, Dict, Optional
from typing_extensions import Self

import msal

Expand Down Expand Up @@ -59,7 +60,7 @@ def __init__(

super(MsalCredential, self).__init__()

def __enter__(self) -> "MsalCredential":
def __enter__(self) -> "Self":
Comment thread
xiangyan99 marked this conversation as resolved.
Outdated
self._client.__enter__()
return self

Expand Down
1 change: 1 addition & 0 deletions sdk/identity/azure-identity/setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,5 +63,6 @@
"cryptography>=2.5",
"msal>=1.24.0",
"msal-extensions>=0.3.0",
"typing-extensions>=4.0.0",
],
)
⚡