[Identity] Fix device code tests#35846
Merged
pvaneck merged 1 commit intoAzure:mainfrom Jun 3, 2024
Merged
Conversation
A recent change in MSAL made it so it is required that "device_authorization_endpoint" is set in the discovery response. This populates the value in the mock discovery response. Signed-off-by: Paul Van Eck <paulvaneck@microsoft.com>
Collaborator
|
API change check API changes are not detected in this pull request. |
pvaneck
requested review from
KarishmaGhiya,
ahsonkhan,
billwert,
chlowell,
maorleger and
mpodwysocki
xiangyan99
approved these changes
Jun 3, 2024
pvaneck
added a commit
that referenced
this pull request
Jun 10, 2024
A recent change in MSAL made it so it is required that "device_authorization_endpoint" is set in the discovery response. This populates the value in the mock discovery response. Signed-off-by: Paul Van Eck <paulvaneck@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A recent change in MSAL made it so that the "device_authorization_endpoint" is no longer faked/populated as it's always expected to be in the discovery response (example). Our tests seemingly relied on this fallback behavior since our mock discovery response didn't return a "device_authorization_endpoint" value. This updates our mock response accordingly.