[Cosmos] fix resource validation to allow longer strings#36569
Merged
simorenoh merged 6 commits intoAzure:mainfrom Jul 24, 2024
Merged
[Cosmos] fix resource validation to allow longer strings#36569simorenoh merged 6 commits intoAzure:mainfrom
simorenoh merged 6 commits intoAzure:mainfrom
Conversation
Collaborator
|
API change check API changes are not detected in this pull request. |
simorenoh
requested review from
Pilchie,
annatisch,
bambriz,
kushagraThapar and
xinlian12
as code owners
xinlian12
reviewed
Jul 23, 2024
l0lawrence
pushed a commit
to l0lawrence/azure-sdk-for-python
that referenced
this pull request
Feb 19, 2025
* relevant changes * Update CHANGELOG.md * Update test_resource_id.py * Update test_resource_id_async.py * test fixes * test fix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #35044 pointed out that we accidentally introduced a limit of 255 characters for all resource ids even though our public docs mention item ids can have up to 1023: https://learn.microsoft.com/en-us/azure/cosmos-db/concepts-limits#per-item-limits
This PR makes the validation not worry about size, since the service will always validate that for each resource.