Align eng/common/scripts/common.ps1#37037
Merged
scbedd merged 1 commit intoAzure:mainfrom Aug 27, 2024
Merged
Conversation
…en the affected function, passing this by praveen prior to merge
praveenkuttappan
approved these changes
Aug 27, 2024
Member
praveenkuttappan
left a comment
praveenkuttappan
left a comment
There was a problem hiding this comment.
This looks fine. This function is used here. If Language-Settings.ps1 does not have a method with name Get-${Language}-ApiviewStatusCheckRequirement then script will fall back to default check.
Member
Author
Thanks Praveen! I confirmed that function is nowhere present in |
l0lawrence
pushed a commit
to l0lawrence/azure-sdk-for-python
that referenced
this pull request
Feb 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey @praveenkuttappan given the fact that we're now defining something that WASNT DEFINED in
common.ps1forpython apiviewbefore, I wanted to get your sign off.I don't have any idea how 8/10 were updated with the new
common.ps1, butpythonandandroidwere left behind 😂This is to unblock
eng/commonpr over in Azure/azure-sdk-tools#8878 which is crashing due to misaligned files.