Skip to content

Distro Release 1.6.4: Fix instrumentation migration bug.#38371

Merged
pvaneck merged 8 commits intoAzure:mainfrom
jeremydvoss:distro-1.6.4-fix
Nov 7, 2024
Merged

Distro Release 1.6.4: Fix instrumentation migration bug.#38371
pvaneck merged 8 commits intoAzure:mainfrom
jeremydvoss:distro-1.6.4-fix

Conversation

@jeremydvoss
Copy link
Copy Markdown
Member

@jeremydvoss jeremydvoss commented Nov 6, 2024 •
edited
Loading

Description

Fix bug by migrating to importlib and incorporating changes in opentelemetry.
Replacing #38366

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@jeremydvoss jeremydvoss requested a review from lzchen as a code owner November 6, 2024 21:37
@github-actions github-actions Bot added the Monitor - Distro Monitor OpenTelemetry Distro label Nov 6, 2024
@jeremydvoss jeremydvoss enabled auto-merge (squash) November 6, 2024 21:54
pvaneck
pvaneck approved these changes Nov 6, 2024
View reviewed changes
Comment thread sdk/monitor/azure-monitor-opentelemetry/CHANGELOG.md Outdated
Comment thread sdk/monitor/azure-monitor-opentelemetry/CHANGELOG.md Outdated
@azure-sdk
Copy link
Copy Markdown
Collaborator

azure-sdk commented Nov 6, 2024

API change check

API changes are not detected in this pull request.

@jeremydvoss jeremydvoss disabled auto-merge November 7, 2024 00:55
hectorhdzg
hectorhdzg approved these changes Nov 7, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@hectorhdzg hectorhdzg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pvaneck pvaneck merged commit 3115481 into Azure:main Nov 7, 2024
l0lawrence pushed a commit to l0lawrence/azure-sdk-for-python that referenced this pull request Feb 19, 2025
@jeremydvoss @pvaneck @l0lawrence
Distro Release 1.6.4: Fix instrumentation migration bug. (Azure#38371)
2b538b0 
* Distro release 1.6.4

* Fixed bug

* Update broken docs links

* Update sdk/monitor/azure-monitor-opentelemetry/CHANGELOG.md

Co-authored-by: Paul Van Eck <paulvaneck@microsoft.com>

* Update sdk/monitor/azure-monitor-opentelemetry/CHANGELOG.md

Co-authored-by: Paul Van Eck <paulvaneck@microsoft.com>

* Update all otel dependencies

* Updated tests

* lint

---------

Co-authored-by: Paul Van Eck <paulvaneck@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pvaneck pvaneck pvaneck approved these changes

@hectorhdzg hectorhdzg hectorhdzg approved these changes

@lzchen lzchen Awaiting requested review from lzchen lzchen is a code owner

Assignees

No one assigned

Labels

Monitor - Distro Monitor OpenTelemetry Distro

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jeremydvoss @azure-sdk @pvaneck @hectorhdzg
⚡