Distro 1.6.7 Hotfix: Adjust to breaking change in opentelemetry-instrumentation#40463
Distro 1.6.7 Hotfix: Adjust to breaking change in opentelemetry-instrumentation#40463lmolkova merged 7 commits intoAzure:mainfrom
Conversation
…metry/_configure.py Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
|
API change check API changes are not detected in this pull request. |
MSNev
left a comment
MSNev
left a comment
There was a problem hiding this comment.
LGTM based on everyone updating to the newer version, just have the question about how this is going to work if someone has this version but an older version of otel installed.
Or do we just say not supported, upgrade everything?
| _logger.debug("Instrumentation skipped for library %s", entry_point.name) | ||
| continue | ||
| try: | ||
| # Check if dependent libraries/version are installed |
There was a problem hiding this comment.
Unless I'm doing something wrong, the removal of this logic causes some messy log messages in our containers - e.g. tracebacks starting like:
Exception occurred when instrumenting: django.
Traceback (most recent call last):
File "/app/.venv/lib/python3.12/site-packages/azure/monitor/opentelemetry/_configure.py", line 222, in _setup_instrumentations
instrumentor: BaseInstrumentor = entry_point.load()
^^^^^^^^^^^^^^^^^^
for all the libraries that aren't installed. Do we now have to explicitly disable these when calling configure_azure_monitor? Are the defaults documented anywhere?
There was a problem hiding this comment.
@dylwil3 please create a new issue (so it won't get overlooked). Thanks!
…umentation (#40463) * Fix breaking change re: dep conflict checks * tests pass * clean up * changelog and min version * Update sdk/monitor/azure-monitor-opentelemetry/azure/monitor/opentelemetry/_configure.py Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * lint: unused imports --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Description
Breaking change detected by pipeline.
Changing configure_azure_monitor to use dependency conflict check inside of instrumentor.instrument.
All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines