Skip to content

[EH/SB/EG] next*#40483

Merged
l0lawrence merged 6 commits intoAzure:mainfrom
l0lawrence:nextfixes
Apr 16, 2025
Merged

[EH/SB/EG] next*#40483
l0lawrence merged 6 commits intoAzure:mainfrom
l0lawrence:nextfixes

Conversation

@l0lawrence
Copy link
Copy Markdown
Member

@l0lawrence l0lawrence commented Apr 11, 2025

No description provided.

kashifkhan
kashifkhan reviewed Apr 11, 2025
View reviewed changes
Comment thread sdk/eventgrid/azure-eventgrid/azure/eventgrid/_legacy/_publisher_client.py Outdated
kashifkhan
kashifkhan reviewed Apr 11, 2025
View reviewed changes
Comment thread sdk/eventgrid/azure-eventgrid/azure/eventgrid/_legacy/_publisher_client.py
kashifkhan
kashifkhan reviewed Apr 11, 2025
View reviewed changes
Comment thread sdk/eventhub/azure-eventhub/azure/eventhub/aio/_async_utils.py Outdated
@azure-sdk
Copy link
Copy Markdown
Collaborator

azure-sdk commented Apr 11, 2025

API change check

API changes are not detected in this pull request.

swathipil
swathipil reviewed Apr 11, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@swathipil swathipil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

generally lgtm!

Comment thread sdk/eventgrid/azure-eventgrid/azure/eventgrid/_legacy/_publisher_client.py
Comment thread sdk/servicebus/azure-servicebus/azure/servicebus/management/_shared_key_policy.py Outdated
Comment thread sdk/servicebus/azure-servicebus/azure/servicebus/management/_utils.py Outdated
@l0lawrence l0lawrence marked this pull request as ready for review April 14, 2025 22:02
@l0lawrence l0lawrence requested a review from annatisch as a code owner April 14, 2025 22:02
@l0lawrence l0lawrence force-pushed the nextfixes branch 2 times, most recently from caeff64 to dcf5dad Compare April 15, 2025 21:33
@l0lawrence
Copy link
Copy Markdown
Member Author

l0lawrence commented Apr 16, 2025 •
edited
Loading

/check-enforcer override

@azure-pipelines
Copy link
Copy Markdown

azure-pipelines Bot commented Apr 16, 2025

Command 'check-enforcer' is not supported by Azure Pipelines.

Supported commands
  • help:
    • Get descriptions, examples and documentation about supported commands
    • Example: help "command_name"
  • list:
    • List all pipelines for this repository using a comment.
    • Example: "list"
  • run:
    • Run all pipelines or specific pipelines for this repository using a comment. Use this command by itself to trigger all related pipelines, or specify specific pipelines to run.
    • Example: "run" or "run pipeline_name, pipeline_name, pipeline_name"
  • where:
    • Report back the Azure DevOps orgs that are related to this repository and org
    • Example: "where"

See additional documentation.

@l0lawrence l0lawrence merged commit f79d1c7 into Azure:main Apr 16, 2025
29 checks passed
cRui861 pushed a commit that referenced this pull request May 14, 2025
@l0lawrence
[EH/SB/EG] next* (#40483)
b494ac7 
* next*

* shouldnt return

* pylint

* this

* this

* tis
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kashifkhan kashifkhan kashifkhan approved these changes

@swathipil swathipil swathipil approved these changes

@annatisch annatisch Awaiting requested review from annatisch

@scbedd scbedd Awaiting requested review from scbedd scbedd is a code owner

@weshaggard weshaggard Awaiting requested review from weshaggard weshaggard is a code owner

@benbp benbp Awaiting requested review from benbp benbp is a code owner

Assignees

No one assigned

Labels

Event Grid Event Hubs Service Bus

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@l0lawrence @azure-sdk @kashifkhan @swathipil
⚡