Skip to content

Sync eng/common directory with azure-sdk-tools for PR 10293#40485

Merged
JoshLove-msft merged 3 commits intomainfrom
sync-eng/common-emitter-ci-updates-10293
Apr 14, 2025
Merged

Sync eng/common directory with azure-sdk-tools for PR 10293#40485
JoshLove-msft merged 3 commits intomainfrom
sync-eng/common-emitter-ci-updates-10293

Conversation

@azure-sdk
Copy link
Copy Markdown
Collaborator

Sync eng/common directory with azure-sdk-tools for PR Azure/azure-sdk-tools#10293 See eng/common workflow

@azure-sdk azure-sdk requested review from JoshLove-msft and Copilot and removed request for JoshLove-msft April 11, 2025 22:32
@azure-sdk azure-sdk requested a review from a team as a code owner April 11, 2025 22:33
@azure-sdk azure-sdk added EngSys This issue is impacting the engineering system. Central-EngSys This issue is owned by the Engineering System team. labels Apr 11, 2025
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.

Comments suppressed due to low confidence (1)

eng/common/pipelines/templates/archetype-typespec-emitter.yml:221

  • There is an inconsistency between the output directories used: the build task now uses '$(Build.ArtifactStagingDirectory)/packages' while tsp-client uses '$(Build.SourcesDirectory)'. Verify that this change is intentional and consistent with the overall pipeline design.
--output-dir '$(Build.SourcesDirectory)'

Comment thread eng/common/pipelines/templates/archetype-typespec-emitter.yml
@azure-sdk azure-sdk force-pushed the sync-eng/common-emitter-ci-updates-10293 branch from 0d03bb0 to 9358c52 Compare April 11, 2025 22:48
@JoshLove-msft JoshLove-msft merged commit b305dc7 into main Apr 14, 2025
17 checks passed
@JoshLove-msft JoshLove-msft deleted the sync-eng/common-emitter-ci-updates-10293 branch April 14, 2025 20:51
cRui861 pushed a commit that referenced this pull request May 14, 2025
* Updates to emitter CI

* add missing $

* add path

---------

Co-authored-by: jolov <jolov@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Central-EngSys This issue is owned by the Engineering System team. EngSys This issue is impacting the engineering system.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants