Sync eng/common directory with azure-sdk-tools for PR 10314#40522
Merged
JoshLove-msft merged 4 commits intomainfrom Apr 16, 2025
Merged
Sync eng/common directory with azure-sdk-tools for PR 10314#40522JoshLove-msft merged 4 commits intomainfrom
JoshLove-msft merged 4 commits intomainfrom
Conversation
azure-sdk
added
EngSys
Contributor
There was a problem hiding this comment.
Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (3)
eng/common/pipelines/templates/archetype-typespec-emitter.yml:329
- The emitterVersion output source has been changed from 'ci_build' to 'initialize'. Please verify that the initialize task correctly produces the emitterVersion output expected by downstream steps.
emitterVersion: $[stageDependencies.Build.Build.outputs['initialize.emitterVersion']]
eng/common/pipelines/templates/archetype-typespec-emitter.yml:415
- [nitpick] The use of double-dollar syntax for variable expansion in '-OpenAsDraft $$(OpenAsDraft)' differs from the single-dollar syntax used elsewhere. Please confirm that this is the intended usage for proper runtime variable expansion.
-OpenAsDraft $$(OpenAsDraft)
eng/common/pipelines/templates/archetype-typespec-emitter.yml:153
- The previous block that generated emitter-package-lock.json and managed publisher artifacts has been removed. Confirm that these changes are intentional and that no downstream dependency on the removed artifacts exists.
# Responsible for publishing the packages in `build_artifacts/packages`
azure-sdk
force-pushed
the
sync-eng/common-move-tsp-client-10314
branch
from
be3ee06 to
7a8ae7d
Compare
JoshLove-msft
approved these changes
Apr 15, 2025
cRui861
pushed a commit
that referenced
this pull request
May 14, 2025
* Move tsp-client step to regenerate stage * Update comment * open as draft logic and fix emitter version * add comment --------- Co-authored-by: jolov <jolov@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sync eng/common directory with azure-sdk-tools for PR Azure/azure-sdk-tools#10314 See eng/common workflow