Request activity#41013
Merged
bambriz merged 10 commits intoAzure:mainfrom May 28, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds client-generated Activity IDs to each request, making diagnostics easier by associating a unique ID with every request and response.
- Updated the HTTP logging policy to log the Activity ID.
- Modified header generation in the base module to include the Activity ID.
- Updated the CHANGELOG to document the new functionality.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| sdk/cosmos/azure-cosmos/azure/cosmos/_cosmos_http_logging_policy.py | Added logging of the Activity ID in both the structured logger and the built log string. |
| sdk/cosmos/azure-cosmos/azure/cosmos/_base.py | Added a header for the Activity ID using a generated GUID. |
| sdk/cosmos/azure-cosmos/CHANGELOG.md | Updated changelog to note the Activity ID change. |
Collaborator
|
API change check API changes are not detected in this pull request. |
simorenoh
requested changes
May 9, 2025
tvaron3
reviewed
May 9, 2025
tvaron3
reviewed
May 9, 2025
Member
tvaron3
left a comment
tvaron3
left a comment
There was a problem hiding this comment.
LGTM besides one small comment. THanks Bryan
Added tests to verify Activity id is generated client side. Proof of client generated activity id can be seen from seeing it in the request headers.
simorenoh
approved these changes
May 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds Client Generated Activity ID to each request. Also adds Activity ID to log record in diagnostics.