[Cosmos] Fix mismatching type of ConsistencyPolicy with docstring#43150
Merged
simorenoh merged 4 commits intoAzure:mainfrom Oct 6, 2025
Merged
[Cosmos] Fix mismatching type of ConsistencyPolicy with docstring#43150simorenoh merged 4 commits intoAzure:mainfrom
ConsistencyPolicy with docstring#43150simorenoh merged 4 commits intoAzure:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a type annotation mismatch for the ConsistencyPolicy attribute in the DatabaseAccount class. The docstring type hint and actual code implementation had inconsistent type annotations.
- Updates docstring type annotation from
Dict[str, Union[str, int]]todict[str, str] - Updates instance variable type annotation from
Optional[UserConsistencyPolicy]toOptional[dict[str, str]]
API Change CheckAPIView identified API level changes in this PR and created the following API reviews |
annatisch
reviewed
Sep 28, 2025
simorenoh
approved these changes
Oct 6, 2025
13 tasks
ConsistencyPolicy with docstringConsistencyPolicy with docstring
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Tackling the bullet point items related to
ConsistencyPolicytype hint for GA release: #43211The typehint for
ConsistencyPolicyin docstring and actual code were mismatching. This fix will sync the typehints for them.All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines