Skip to content

Default credentials are configurable by kwargs#8514

Merged
chlowell merged 4 commits intoAzure:masterfrom
chlowell:default-options
Nov 14, 2019
Merged

Default credentials are configurable by kwargs#8514
chlowell merged 4 commits intoAzure:masterfrom
chlowell:default-options

Conversation

@chlowell
Copy link
Copy Markdown
Member

@chlowell chlowell commented Nov 7, 2019

Closes #7991 with optional keyword arguments to DefaultAzureCredential that allow excluding specific credential types, as in the .NET implementation.

@chlowell chlowell added Client This issue points to a problem in the data-plane of the library. Azure.Identity labels Nov 7, 2019
@chlowell chlowell requested a review from schaabs as a code owner November 7, 2019 23:42
@chlowell chlowell self-assigned this Nov 7, 2019
@adxsdk6
Copy link
Copy Markdown

adxsdk6 commented Nov 7, 2019

Can one of the admins verify this patch?

Copy link
Copy Markdown
Member

@KieranBrantnerMagee KieranBrantnerMagee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small nits for clarity. Overall LGTM.

Comment thread sdk/identity/azure-identity/tests/test_default.py Outdated
Comment thread sdk/identity/azure-identity/tests/test_default_async.py Outdated
@chlowell chlowell merged commit 1f32b91 into Azure:master Nov 14, 2019
@chlowell chlowell deleted the default-options branch November 14, 2019 21:39
xiangyan99 added a commit that referenced this pull request Nov 15, 2019
* InteractiveBrowserCredential prompts for account selection (#8470)

* remove *.yaml under tests folder from manifest.in (#8625)

* [AutoPR] cosmos-db/resource-manager (#8560)

* regenerated

* fix script

* another place

* fix

* fix

* one more change

* one more

* undo multiapi script

* regeneated

* undo multiapi script

* history, version + additional fix

* regenerated

* fixed test

* fixed generation mistake

* added more breaking changes to history

* regenerated again

* additional fixes

* udpated test names

* test recordings

* Update README.md (#8628)

Add standard section on security issues below the "file an issue via GitHub Issues' bullet.

* Handle exceptions when constructing DefaultAzureCredential (#8294)

* Python 3.8 test pipeline is not cancelled when build is cancelled (#8544)

* Skip python 3.8 testing when CI is cancelled

* Cosmos docstring review (#8607)

* cosmos docstring edits

* user-defined

* trailing whitespace

* xfail flaky emulator tests

* review feedback

* Default credentials are configurable by kwargs (#8514)

* Nightly build is failing due version conflict between storage datalak… (#8635)

* Nightly build is failing due version conflict between storage datalake and storage blob

* InkRecognizer to use GA azure-core (#8341)

* InkRecognizer to use Ga azure-core

* Disable auto-pr update

* Azconfig remove tests from whl (#8663)

* update tests

* ignoring the azure folder directly (#8673)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Azure.Identity Client This issue points to a problem in the data-plane of the library.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add optional configuration to DefaultAzureCredential

3 participants