Remove "Mark as Reviewed" feature from APIView (#13229)

* Initial plan

* Remove Mark as Reviewed/Viewed feature from APIView

Co-authored-by: tjprescott <5723682+tjprescott@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: tjprescott <5723682+tjprescott@users.noreply.github.com>

Author: Copilot

src/dotnet/APIView/APIViewUnitTests/APIRevisionsControllerTests.cs

@@ -289,7 +289,6 @@ private static APIRevisionListItemModel CreateMockAPIRevision(
             Files = [new APICodeFileModel { FileId = "1" }],
             ChangeHistory = [],
             Approvers = [],
-            ViewedBy = [],
             AssignedReviewers = [],
             HeadingsOfSectionsWithDiff = new Dictionary<string, HashSet<int>>()
         };

src/dotnet/APIView/APIViewUnitTests/CommentsTokenAuthControllerTests.cs

@@ -100,7 +100,6 @@ private static APIRevisionListItemModel CreateMockAPIRevision(string id)
             Files = [new APICodeFileModel { FileId = "file1" }],
             ChangeHistory = [],
             Approvers = [],
-            ViewedBy = [],
             AssignedReviewers = [],
             HeadingsOfSectionsWithDiff = new Dictionary<string, HashSet<int>>()
         };

src/dotnet/APIView/APIViewWeb/Client/src/pages/review.ts

@@ -236,10 +236,6 @@ $(() => {
   $("#reviewSubscribeSwitch").on('change', function () {
     $("#reviewSubscribeForm").submit();
   });
-  // Toggle Viewed Switch
-  $("#reviewViewedSwitch").on('change', function () {
-    $("#reviewViewedForm").submit();
-  });
   // Toggle Close Switch
   $("#reviewCloseSwitch").on('change', function () {
     $("#reviewCloseForm").submit();

src/dotnet/APIView/APIViewWeb/LeanControllers/APIRevisionsController.cs

@@ -155,31 +155,6 @@ public async Task RestoreAPIRevisionsAsync([FromBody] APIRevisionSoftDeleteParam
             }
         }
 
-        /// <summary>
-        /// Endpoint used by Client SPA toggling ViewdBy property
-        /// </summary>
-        /// <param name="apiRevisionId"></param>
-        /// <param name="state"></param> true = viewed, false = not viewed
-        /// <returns></returns>
-        [HttpPost("{apiRevisionId}/toggleViewedBy", Name = "ToggleViewedBy")]
-        public async Task<ActionResult<APIRevisionListItemModel>> ToggleViewedByAsync(string apiRevisionId, [FromQuery] bool state)
-        {
-            string userName = User.GetGitHubLogin();
-            var apiRevision = await _apiRevisionsManager.GetAPIRevisionAsync(apiRevisionId);
-
-            if (state)
-            {
-                apiRevision.ViewedBy.Add(userName);
-            }
-            else 
-            {
-                apiRevision.ViewedBy.Remove(userName);
-            }
-
-            await _apiRevisionsManager.UpdateAPIRevisionAsync(apiRevision);
-            return new LeanJsonResult(apiRevision, StatusCodes.Status200OK);
-        }
-
         /// <summary>
         /// Endpoint used by Client SPA for Toggling APIRevision Approval
         /// </summary>

src/dotnet/APIView/APIViewWeb/LeanModels/ReviewListModels.cs

@@ -156,7 +156,6 @@ public string PackageVersion
         public bool IsDeleted { get; set; }
         public bool IsReleased { get; set; }
         public DateTime ReleasedOn { get; set; }
-        public HashSet<string> ViewedBy { get; set; } = new HashSet<string>();
     }
 
 

src/dotnet/APIView/APIViewWeb/Pages/Assemblies/Review.cshtml

@@ -487,24 +487,7 @@
         }
         <ul class="list-group collapse mb-3@(apiRevisionOptionsCollapseState)" id="apiRevisionOptionsCollapse">
             <li class="list-group-item">
-                <div class="form-check form-switch">
-                    <form asp-resource="@Model.ReviewContent.ActiveAPIRevision" class="form-inline" id="reviewViewedForm" method="post" asp-page-handler="ToggleViewed">
-                        <input type="hidden" name="revisionId" value="@Model.ReviewContent.ActiveAPIRevision.Id" />
-                        @if (Model.ReviewContent.ActiveAPIRevision.ViewedBy.Contains(User.GetGitHubLogin()))
-                        {
-                            <input class="form-check-input" checked type="checkbox" role="switch" id="reviewViewedSwitch">
-                        }
-                        else
-                        {
-                            <input class="form-check-input" type="checkbox" role="switch" id="reviewViewedSwitch">
-                        }
-
-                        <label class="form-check-label" for="reviewViewedSwitch">Mark as Viewed</label>
-                    </form>
-                </div>
-            </li>
-            <li class="list-group-item">
-                <div>
+                <div>
                     <p class="small revision-title">Change History:</p>
                         @foreach (var change in Model.ReviewContent.ActiveAPIRevision.ChangeHistory)
                         {

src/dotnet/APIView/APIViewWeb/Pages/Assemblies/Review.cshtml.cs

@@ -285,30 +285,6 @@ public async Task<ActionResult> OnPostToggleSubscribedAsync(string id)
             return RedirectToPage(new { id = id });
         }
 
-        /// <summary>
-        /// Mark a Review as Viewed
-        /// </summary>
-        /// <param name="id"></param>
-        /// <param name="revisionId"></param>
-        /// <returns></returns>
-        public async Task<ActionResult> OnPostToggleViewedAsync(string id, string revisionId)
-        {
-            string userName = User.GetGitHubLogin();
-            var revision = await _apiRevisionsManager.GetAPIRevisionAsync(revisionId);
-
-            if (revision.ViewedBy.Contains(userName))
-            {
-                revision.ViewedBy.Remove(userName);
-            }
-            else
-            {
-                revision.ViewedBy.Add(userName);
-            }
-
-            await _apiRevisionsManager.UpdateAPIRevisionAsync(revision);
-            return RedirectToPage(new { id = id, revisionId = revisionId });
-        }
-
         /// <summary>
         /// Approve or Revert Approval for a Review
         /// </summary>

src/dotnet/APIView/ClientSPA/src/app/_components/review-page-options/review-page-options.component.html

@@ -197,11 +197,6 @@
 
     <app-page-options-section sectionName="API Revision Options">
     <ul class="list-group">
-        <li class="list-group-item">
-            <p-inputSwitch [(ngModel)]="markedAsViewSwitch"
-            (onChange)="onMarkedAsViewedSwitchChange($event)" data-clarity-region="toggle-marked-as-viewed" />
-            <label class="ms-2">Mark as viewed</label>
-        </li>
         <li class="list-group-item">
             <label class="small mx-1 fw-semibold" for="diff-style-select">Reviewers :</label>
             <p-multiSelect

src/dotnet/APIView/ClientSPA/src/app/_components/review-page-options/review-page-options.component.spec.ts

@@ -104,7 +104,6 @@ describe('ReviewPageOptionsComponent', () => {
       expect(component.showDocumentationSwitch).toEqual(true);
       expect(component.showHiddenAPISwitch).toEqual(false);
       expect(component.showLeftNavigationSwitch).toEqual(true);
-      expect(component.markedAsViewSwitch).toEqual(false);
       expect(component.showLineNumbersSwitch).toEqual(true);
       expect(component.disableCodeLinesLazyLoading).toEqual(false);
     })

src/dotnet/APIView/ClientSPA/src/app/_components/review-page-options/review-page-options.component.ts

@@ -52,7 +52,6 @@ export class ReviewPageOptionsComponent implements OnInit, OnChanges {
   @Output() showHiddenAPIEmitter : EventEmitter<boolean> = new EventEmitter<boolean>();
   @Output() showLeftNavigationEmitter : EventEmitter<boolean> = new EventEmitter<boolean>();
   @Output() disableCodeLinesLazyLoadingEmitter : EventEmitter<boolean> = new EventEmitter<boolean>();
-  @Output() markAsViewedEmitter : EventEmitter<boolean> = new EventEmitter<boolean>();
   @Output() subscribeEmitter : EventEmitter<boolean> = new EventEmitter<boolean>();
   @Output() showLineNumbersEmitter : EventEmitter<boolean> = new EventEmitter<boolean>();
   @Output() apiRevisionApprovalEmitter : EventEmitter<boolean> = new EventEmitter<boolean>();
@@ -74,7 +73,6 @@ export class ReviewPageOptionsComponent implements OnInit, OnChanges {
   showDocumentationSwitch : boolean = true;
   showHiddenAPISwitch : boolean = false;
   showLeftNavigationSwitch : boolean = true;
-  markedAsViewSwitch : boolean = false;
   subscribeSwitch : boolean = false;
   showLineNumbersSwitch : boolean = true;
   disableCodeLinesLazyLoading: boolean = false;
@@ -170,12 +168,10 @@ export class ReviewPageOptionsComponent implements OnInit, OnChanges {
 
     if (changes['userProfile'] && changes['userProfile'].currentValue != undefined) {
       this.setSubscribeSwitch();
-      this.setMarkedAsViewSwitch();
       this.setPageOptionValues();
     }
 
     if (changes['activeAPIRevision'] && changes['activeAPIRevision'].currentValue != undefined) {
-      this.setMarkedAsViewSwitch();
       this.selectedApprovers = this.activeAPIRevision!.assignedReviewers.map(reviewer => reviewer.assingedTo);
       this.isCopilotReviewSupported = this.isCopilotReviewSupportedForPackage();
       this.setAPIRevisionApprovalStates();
@@ -294,15 +290,7 @@ export class ReviewPageOptionsComponent implements OnInit, OnChanges {
   }
 
   /**
-  * Callback for markedAsViewSwitch Change
-  * @param event the Filter event
-  */
-  onMarkedAsViewedSwitchChange(event: InputSwitchChangeEvent) {
-    this.markAsViewedEmitter.emit(event.checked);
-  }
-
-  /**
-  * Callback for markedAsViewSwitch Change
+  * Callback for subscribeSwitch Change
   * @param event the Filter event
   */
   onSubscribeSwitchChange(event: InputSwitchChangeEvent) {
@@ -465,10 +453,6 @@ export class ReviewPageOptionsComponent implements OnInit, OnChanges {
     this.subscribeSwitch = (this.userProfile && this.review) ? this.review!.subscribers.includes(this.userProfile?.email!) : this.subscribeSwitch;
   }
 
-  setMarkedAsViewSwitch() {
-    this.markedAsViewSwitch = (this.activeAPIRevision && this.userProfile)? this.activeAPIRevision!.viewedBy.includes(this.userProfile?.userName!): this.markedAsViewSwitch;
-  }
-
   copyReviewText(event: Event) {
     const icon = (event?.target as Element).firstChild as HTMLElement;