Remove "Mark as Reviewed" feature from APIView#13229
Merged
tjprescott merged 2 commits intomainfrom Dec 5, 2025
Merged
Conversation
Co-authored-by: tjprescott <5723682+tjprescott@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Remove 'Mark as Reviewed' feature from API view
Remove "Mark as Reviewed" feature from APIView
Dec 5, 2025
tjprescott
approved these changes
Dec 5, 2025
Member
tjprescott
left a comment
There was a problem hiding this comment.
This is on UX test and works fine. This seems to appropriately clean up the code, as well. @AlitzelMendez for final approval.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes the incomplete "Mark as Reviewed" feature that was originally added in PR #7959. The feature allowed marking revisions as viewed but never implemented the intended filtering functionality, making it non-functional. This change comprehensively removes all traces of the feature from both backend and frontend codebases.
- Removes the
ViewedByproperty and associated toggle endpoints from the backend API - Removes all "Mark as Viewed" UI controls and handlers from both Angular SPA and Razor frontends
- Updates test helpers to reflect the model changes
Reviewed changes
Copilot reviewed 14 out of 14 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
src/dotnet/APIView/APIViewWeb/LeanModels/ReviewListModels.cs |
Removes ViewedBy property from APIRevisionListItemModel |
src/dotnet/APIView/APIViewWeb/LeanControllers/APIRevisionsController.cs |
Removes ToggleViewedByAsync endpoint that toggled the ViewedBy state |
src/dotnet/APIView/APIViewWeb/Pages/Assemblies/Review.cshtml.cs |
Removes OnPostToggleViewedAsync handler from Review page |
src/dotnet/APIView/APIViewWeb/Pages/Assemblies/Review.cshtml |
Removes "Mark as Viewed" toggle UI from the Razor view |
src/dotnet/APIView/APIViewWeb/Client/src/pages/review.ts |
Removes reviewViewedSwitch event handler |
src/dotnet/APIView/ClientSPA/src/app/_models/revision.ts |
Removes viewedBy property from APIRevision model |
src/dotnet/APIView/ClientSPA/src/app/_services/revisions/revisions.service.ts |
Removes toggleAPIRevisionViewedByForUser service method |
src/dotnet/APIView/ClientSPA/src/app/_components/review-page/review-page.component.ts |
Removes handleMarkAsViewedEmitter handler |
src/dotnet/APIView/ClientSPA/src/app/_components/review-page/review-page.component.html |
Removes markAsViewedEmitter binding from template |
src/dotnet/APIView/ClientSPA/src/app/_components/review-page-options/review-page-options.component.ts |
Removes markedAsViewSwitch property, emitter, and related methods |
src/dotnet/APIView/ClientSPA/src/app/_components/review-page-options/review-page-options.component.html |
Removes "Mark as viewed" toggle from options panel |
src/dotnet/APIView/ClientSPA/src/app/_components/review-page-options/review-page-options.component.spec.ts |
Updates test expectations to remove markedAsViewSwitch assertion |
src/dotnet/APIView/APIViewUnitTests/APIRevisionsControllerTests.cs |
Updates test helper to remove ViewedBy initialization |
src/dotnet/APIView/APIViewUnitTests/CommentsTokenAuthControllerTests.cs |
Updates test helper to remove ViewedBy initialization |
AlitzelMendez
approved these changes
Dec 5, 2025
Member
|
/check-enforcer evaluate |
JiaqiZhang-Dev
pushed a commit
that referenced
this pull request
Dec 22, 2025
* Initial plan * Remove Mark as Reviewed/Viewed feature from APIView Co-authored-by: tjprescott <5723682+tjprescott@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: tjprescott <5723682+tjprescott@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The "Mark as Reviewed" feature (implemented in PR #7959) was incomplete—it allowed marking revisions as viewed but never implemented the filtering functionality that was its original purpose. This removes the non-functional feature entirely.
Backend
ViewedByproperty fromAPIRevisionListItemModelToggleViewedByAsyncendpoint fromAPIRevisionsControllerOnPostToggleViewedAsynchandler from Review pageFrontend (Razor)
Review.cshtmlreviewViewedSwitchhandler fromreview.tsFrontend (Angular SPA)
viewedByfromAPIRevisionmodeltoggleAPIRevisionViewedByForUserfrom revisions servicemarkedAsViewSwitchand related handlers from review-page-options componenthandleMarkAsViewedEmitterfrom review-page componentTests
APIRevisionsControllerTestsandCommentsTokenAuthControllerTeststest helpersreview-page-options.component.spec.tsOriginal prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.