-
Notifications
You must be signed in to change notification settings - Fork 235
[PR Workflow] Automatic ARM sign-off for TypeSpec-based PRs #7352
Copy link
Copy link
Open
Labels
Central-EngSysThis issue is owned by the Engineering System team.This issue is owned by the Engineering System team.Spec PR ToolsTooling that runs in azure-rest-api-specs repo.Tooling that runs in azure-rest-api-specs repo.openapi-alpsItems pertaining to https://devdiv.visualstudio.com/DevDiv/_git/openapi-alps/Items pertaining to https://devdiv.visualstudio.com/DevDiv/_git/openapi-alps/specs-modelIssues requiring logic to be implemented by https://github.com/Azure/azure-sdk-tools/issues/8203Issues requiring logic to be implemented by https://github.com/Azure/azure-sdk-tools/issues/8203
Metadata
Metadata
Assignees
Labels
Central-EngSysThis issue is owned by the Engineering System team.This issue is owned by the Engineering System team.Spec PR ToolsTooling that runs in azure-rest-api-specs repo.Tooling that runs in azure-rest-api-specs repo.openapi-alpsItems pertaining to https://devdiv.visualstudio.com/DevDiv/_git/openapi-alps/Items pertaining to https://devdiv.visualstudio.com/DevDiv/_git/openapi-alps/specs-modelIssues requiring logic to be implemented by https://github.com/Azure/azure-sdk-tools/issues/8203Issues requiring logic to be implemented by https://github.com/Azure/azure-sdk-tools/issues/8203
We have now reached a state with the set of linter rule automation that have been put in place where we can start enabling more self-serve scenarios and simplify the PR review process for RP owners.
The first step towards this is to automatically sign-off the PRs that are raised for open api specs that are generated from Typespec. After reviewing a bunch of PRs that were created for Typespec based PRs, we have reached a conclusion that we can automatically sign-off these PRs without requiring a manual review.
Criteria to be met for an automatic sign-off
Swagger LintdiffandSwagger Lintdiff (RPaaS))TypeSpeclabel if appropriate files are changed #7353Mechanism to indicate sign-off
Prerequisites before this automation is put in place in production
Edit by kojamroz:
Related doc in ARM wiki: