Feature/cross language API revision context#7849
Merged
praveenkuttappan merged 5 commits intoAzure:mainfrom Mar 11, 2024
Merged
Feature/cross language API revision context#7849praveenkuttappan merged 5 commits intoAzure:mainfrom
praveenkuttappan merged 5 commits intoAzure:mainfrom
Conversation
Show menu for loading cross language view Show menu for loading cross language view Experiments in CrossLanguage APIView Cross Language View POC Show Cross Language Panel Fix Misc Issues More work on Cross Language View Remove Stale Code Add Custom Model Binder Add Language Customizations Implement Cross Language View in Context Updates to Comment for Cross Language
| { | ||
| var correspondingReviewId = await _apiRevisionsManager.GetReviewIdsOfLanguageCorrespondingReviewAsync(ReviewContent.ActiveAPIRevision.Files.First().CrossLanguagePackageId); | ||
| var correspondingReviews = await _reviewManager.GetReviewsAsync(reviewIds: correspondingReviewId, isClosed: false); | ||
| foreach (var review in correspondingReviews) |
Member
There was a problem hiding this comment.
Will those cause perf issue when loading all related reviews? This looks like caching all related review contents. right?
Member
Author
There was a problem hiding this comment.
Potentially. But for regular sized reviews that I have tested it is performing fine.
praveenkuttappan
approved these changes
Mar 9, 2024
Member
praveenkuttappan
left a comment
praveenkuttappan
left a comment
There was a problem hiding this comment.
Looks fine except the question about a performance when loading a review.
chidozieononiwu
force-pushed
the
feature/CrossLanguageAPIRevisionContext
branch
from
63e74a5 to
ffb347f
Compare
praveenkuttappan
added
APIView
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves APIView (view)