Conversation
benbp
added
the
Central-EngSys
|
The following pipelines have been queued for testing: |
| @@ -48,10 +65,10 @@ steps: | |||
|
|
|||
| if ($repository.Commitish -match '^refs/pull/\d+/merge$') { | |||
| Write-Host "git clone --no-checkout --filter=tree:0 -c remote.origin.fetch='+$($repository.Commitish):refs/remotes/origin/$($repository.Commitish)' https://github.com/$($repository.Name) ." | |||
There was a problem hiding this comment.
Should we move the command logging into this retry function now as well? Just a way to save some lines of our inline script and also reduce some duplication of the command.
There was a problem hiding this comment.
Yeah I could move all logging into the function, and make it a generic runner with a retries int, that way we can pass all commands through it.
There was a problem hiding this comment.
@weshaggard ok made this update here. Overdue anyway.
|
The following pipelines have been queued for testing: |
| Write-Host "git sparse-checkout set --no-cone '/*' '!/*/' '/eng'" | ||
| git sparse-checkout set --no-cone '/*' '!/*/' '/eng' | ||
| } | ||
|
|
There was a problem hiding this comment.
Do you remember why we used Invoke-Expression in the lines below? If not needed we could use the Run there as well.
There was a problem hiding this comment.
I had a lot of issues with commands that contained any sort of glob/wildcard when sourcing those values dynamically. We may be able to improve upon this by using invoke expression everywhere, I will have to test it out.
Sync eng/common directory with azure-sdk-tools for PR Azure/azure-sdk-tools#8019 See [eng/common workflow](https://github.com/Azure/azure-sdk-tools/blob/main/eng/common/README.md#workflow) --------- Co-authored-by: Ben Broderick Phillips <bebroder@microsoft.com>
4 participants
No description provided.