Merged
Conversation
weshaggard
reviewed
Apr 8, 2024
|
|
||
| DateTimeOffset? warningThresholdDate = WarningThreshold.HasValue | ||
| ? this.timeProvider.GetCurrentDateTimeOffset().Add(WarningThreshold.Value) | ||
| : default; |
Member
There was a problem hiding this comment.
should we have a smart default? Perhaps half the time of the expire?
Member
Author
There was a problem hiding this comment.
I think that will be rotationThreshold / 2.
For the config:
{
"rotationPeriod": ".180.00:00:00",
"rotationThreshold": "30.00:00:00"
}we'd get the implicit:
"warningThreshold": "15.00:00:00"meaning, we create a 180 day secret and rotate it 30 days before expiration. If we haven't rotated it 15 days before expiration, we start reporting a warning
weshaggard
approved these changes
Apr 8, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change allows for a secret to be in a warning state (should have been rotated previously and is close to expiration) and replaces the state booleans
Expired,ThresholdExpired, and nowWarningExpiredwith a single state enum:If any secret enters the WarningThreshold, the cli will categorize it as Expiring and the status command will return a non-zero exit code.
The WarningThreshold for plans should be configured so there is reasonable time past the RotationThreshold to allow for rotation and prevent unnecessary warnings.