Introducing a test framework for Java APIView processor#8115
Merged
JonathanGiles merged 2 commits intoAzure:mainfrom Apr 17, 2024
Merged
Introducing a test framework for Java APIView processor#8115JonathanGiles merged 2 commits intoAzure:mainfrom
JonathanGiles merged 2 commits intoAzure:mainfrom
Conversation
…tput for published libraries against their known-good representations, to help avoid regrettable regressions
JonathanGiles
added
the
APIView
srnagar
approved these changes
Apr 17, 2024
| // Write out to the filesystem, make the file if it doesn't exist | ||
| if (!outputFile.exists()) { | ||
| if (!outputFile.createNewFile()) { | ||
| System.out.printf("Failed to create output file %s%n", outputFile); |
Member
There was a problem hiding this comment.
Same here - exit if file cannot be created.
Member
Author
There was a problem hiding this comment.
in this case I think we keep going - just because we support multiple files, and the others might work.
alzimmermsft
approved these changes
Apr 17, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introducing a test framework for Java APIView processor to compare output for published libraries against their known-good representations, to help avoid regrettable regressions. So far there are no tests included - this is just the framework.