Skip to content

Prevent release with critical failures#8198

Merged
WhitShake merged 13 commits intoAzure:mainfrom
WhitShake:prevent-release-with-critical-failures
May 7, 2024
Merged

Prevent release with critical failures#8198
WhitShake merged 13 commits intoAzure:mainfrom
WhitShake:prevent-release-with-critical-failures

Conversation

@WhitShake
Copy link
Copy Markdown
Contributor

User will be notified via popup if Fatal diagnostics or open conversations are present when attempting approval. Issue checkboxes must be checked to override and continue approval.

Comment thread src/dotnet/APIView/APIViewWeb/Client/css/shared/codeline.scss
Comment thread src/dotnet/APIView/APIViewWeb/Client/css/shared/codeline.scss Outdated
Comment thread src/dotnet/APIView/APIViewWeb/Pages/Assemblies/Review.cshtml Outdated
Comment thread src/dotnet/APIView/APIViewWeb/Pages/Assemblies/Review.cshtml.cs Outdated
Comment thread src/dotnet/APIView/APIViewWeb/Pages/Assemblies/Review.cshtml.cs Outdated
Copy link
Copy Markdown
Member

@chidozieononiwu chidozieononiwu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets deploy to staging to test it out. Also seems like the razor pages got screwed up a bit. Happens at time will need to take a closer look.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants