CODEOWNERS linter yml updates#8267
Merged
JimSuplizio merged 2 commits intoAzure:mainfrom May 16, 2024
Merged
Conversation
JimSuplizio
added
the
CODEOWNERS Linter
Collaborator
|
The following pipelines have been queued for testing: |
weshaggard
reviewed
May 14, 2024
weshaggard
approved these changes
May 14, 2024
Member
weshaggard
left a comment
weshaggard
left a comment
There was a problem hiding this comment.
Looks good once you finish your testing.
Collaborator
|
The following pipelines have been queued for testing: |
kurtzeborn
approved these changes
May 14, 2024
This was referenced May 16, 2024
JimSuplizio
added a commit
to Azure/azure-sdk-for-js
that referenced
this pull request
May 16, 2024
Sync eng/common directory with azure-sdk-tools for PR Azure/azure-sdk-tools#8267 See [eng/common workflow](https://github.com/Azure/azure-sdk-tools/blob/main/eng/common/README.md#workflow) --------- Co-authored-by: James Suplizio <jasupliz@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These is the yml changes for the linter update.
Testing was done by pushing test commits with errors in their CODEOWNERS files that were removed from the baseline errors as part of their PRs. This means that only by using the generated base branch baseline file would they have passed.
PR with main as the base branch and its codeowners-linter run
PR with a feature branch as the base branch and its codeowners-linter run
These cases were necessary to test the inline powershell scripts that swap the branch to the base branch to create the base branch baseline file and swap back to run the linter against the files in the PR, which only passed because of the base branch baseline file.