Skip to content

Update APIView script path to absolute path#8283

Merged
praveenkuttappan merged 2 commits intoAzure:mainfrom
praveenkuttappan:fix_create_api_review_path
May 17, 2024
Merged

Update APIView script path to absolute path#8283
praveenkuttappan merged 2 commits intoAzure:mainfrom
praveenkuttappan:fix_create_api_review_path

Conversation

@praveenkuttappan
Copy link
Copy Markdown
Member

Use absolute path with parameter root path as prefix to run create api review script so that this template can be used in Java release pipeline.

@praveenkuttappan praveenkuttappan self-assigned this May 16, 2024
@praveenkuttappan praveenkuttappan added APIView Issues related to APIView core functionality or UI Central-EngSys This issue is owned by the Engineering System team. labels May 16, 2024
@azure-sdk
Copy link
Copy Markdown
Collaborator

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

- ${{ if or(ne(parameters.GenerateApiReviewForManualOnly, true), eq(variables['Build.Reason'], 'Manual')) }}:
- task: Powershell@2
inputs:
filePath: ./eng/common/scripts/Create-APIReview.ps1
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why didn't this work?

Copy link
Copy Markdown
Member Author

@praveenkuttappan praveenkuttappan May 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PowerApps task powershell@2 did not honor the WorkingDirectory param. I see that it's documented but current directory was still default source path (first cloned repo). I will check more to find out the root cause with a small repro and report an issue in Devops page if this turns out as an issue in the task itself.

Copy link
Copy Markdown
Member

@weshaggard weshaggard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

curious why the other option didn't work but fine with this as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

APIView Issues related to APIView core functionality or UI Central-EngSys This issue is owned by the Engineering System team.

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

3 participants