Fix default value for env vars in build-test-resource-config template#8528
Merged
benbp merged 3 commits intoAzure:mainfrom Jul 3, 2024
Merged
Fix default value for env vars in build-test-resource-config template#8528benbp merged 3 commits intoAzure:mainfrom
benbp merged 3 commits intoAzure:mainfrom
Conversation
benbp
added
the
Central-EngSys
weshaggard
approved these changes
Jul 1, 2024
Collaborator
|
The following pipelines have been queued for testing: |
This was referenced Jul 1, 2024
Collaborator
|
The following pipelines have been queued for testing: |
azure-sdk
added a commit
to Azure/azure-sdk-for-js
that referenced
this pull request
Jul 3, 2024
Sync eng/common directory with azure-sdk-tools for PR Azure/azure-sdk-tools#8528 See [eng/common workflow](https://github.com/Azure/azure-sdk-tools/blob/main/eng/common/README.md#workflow) --------- Co-authored-by: Ben Broderick Phillips <bebroder@microsoft.com>
weshaggard
reviewed
Jul 3, 2024
| steps: | ||
| - task: AzurePowerShell@5 | ||
| displayName: Set Pipeline Subnet Info | ||
| condition: ne(variables['Pool'], '') |
Member
There was a problem hiding this comment.
Should also add succeeded into the condition otherwise this might try to run when earlier steps have failed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The null default breaks any pipelines that don't specify env vars