Skip to content

[test-proxy] Only remove session once body has been written#8709

Merged
scbedd merged 10 commits intomainfrom
test-proxy-client-retry
Jul 30, 2024
Merged

[test-proxy] Only remove session once body has been written#8709
scbedd merged 10 commits intomainfrom
test-proxy-client-retry

Conversation

@mikeharder
Copy link
Copy Markdown
Member

@mikeharder mikeharder commented Jul 26, 2024

  • Minimizes window of race condition, where client retries after test-proxy has already removed session
  • Prevents needless locks in HandlePlaybackRequest

@mikeharder mikeharder marked this pull request as ready for review July 26, 2024 05:39
@mikeharder mikeharder requested review from benbp and scbedd as code owners July 26, 2024 05:39
@mikeharder mikeharder self-assigned this Jul 26, 2024
Comment thread tools/test-proxy/Azure.Sdk.Tools.TestProxy/RecordingHandler.cs Outdated
Comment thread tools/test-proxy/Azure.Sdk.Tools.TestProxy/Common/RecordSession.cs
Comment thread tools/test-proxy/Azure.Sdk.Tools.TestProxy/RecordingHandler.cs
@scbedd scbedd self-assigned this Jul 30, 2024
@scbedd scbedd merged commit f3e3a51 into main Jul 30, 2024
@scbedd scbedd deleted the test-proxy-client-retry branch July 30, 2024 18:03
This was referenced Jul 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

3 participants