Ensure assets resolution script handles special-case file paths#8831
Merged
scbedd merged 2 commits intoAzure:mainfrom Aug 15, 2024
Merged
Ensure assets resolution script handles special-case file paths#8831scbedd merged 2 commits intoAzure:mainfrom
scbedd merged 2 commits intoAzure:mainfrom
Conversation
…wise files with [ or ] will break powershell when writing the file to disk
scbedd
changed the title
Collaborator
|
The following pipelines have been queued for testing: |
Collaborator
|
The following pipelines have been queued for testing: |
weshaggard
approved these changes
Aug 14, 2024
This was referenced Aug 15, 2024
scbedd
added a commit
to Azure/azure-sdk-for-js
that referenced
this pull request
Aug 15, 2024
Sync eng/common directory with azure-sdk-tools for PR Azure/azure-sdk-tools#8831 See [eng/common workflow](https://github.com/Azure/azure-sdk-tools/blob/main/eng/common/README.md#workflow) --------- Co-authored-by: Scott Beddall <scbedd@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Basically, when we're merging a commit into another, we need there to be a "change" in a file so that
test-proxy pushworks without any weirdness.When the first file discovered contained
[or]powershell will break when attempting to add content to the file path. You have to call it out withLiteralPathto honor paths with these characters in it.Sorry for for the inconvenience @jalauzon-msft !