feat(pylint): Add httpx as a blocked networking import#8870
Merged
l0lawrence merged 2 commits intoAzure:mainfrom Aug 26, 2024
Merged
feat(pylint): Add httpx as a blocked networking import#8870l0lawrence merged 2 commits intoAzure:mainfrom
l0lawrence merged 2 commits intoAzure:mainfrom
Conversation
kdestin
force-pushed
the
add-httpx-as-banned-networking-import
branch
from
de0999a to
6f8cde1
Compare
kdestin
force-pushed
the
add-httpx-as-banned-networking-import
branch
from
6f8cde1 to
e2fa32e
Compare
l0lawrence
approved these changes
Aug 26, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request extends code
C4749ofazure-pylint-guidelines-checkerto also disallow imports of thehttpxpackage, "a fully featured HTTP client library for Python 3".This change should have no impact on any SDK currently in the azure-sdk-for-python (as of commit 99bfd773), since no SDK directly imports
httpx.Background
My team is currently working on adding a new SDK to azure-sdk-for-python, and I noticed that
C4749wasn't flagging our use ofhttpxthat would need to be changed per the Azure SDK guidelines around networking imports.cc: @l0lawrence