Clarify guidelines for LRO subtypes#8181
Merged
annelo-msft merged 1 commit intoAzure:mainfrom Oct 30, 2024
Merged
Conversation
annelo-msft
requested review from
KrzysztofCwalina,
salameer and
tg-msft
as code owners
Contributor
Author
|
@weshaggard, could you advise regarding why the CI is failing for this PR? |
Member
|
This was an issue I fixed earlier today. I just retried your ci check and it should get past this issue. |
KrzysztofCwalina
approved these changes
Oct 30, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If an Azure service provides a REST API to cancel a long-running operation, .NET Azure client libraries put the
Cancelmethod on a public subtype ofOperation. This is not clearly represented in the C# guidelines -- this PR updates the guidelines to reflect the guidance more clearly.