Skip to content

fix: update e2e-ml-workflow deps to fix deployment container crash#3847

Open
Chakradhar886 wants to merge 14 commits intomainfrom
fix/e2e-ml-workflow-update-deps
Open

fix: update e2e-ml-workflow deps to fix deployment container crash#3847
Chakradhar886 wants to merge 14 commits intomainfrom
fix/e2e-ml-workflow-update-deps

Conversation

@Chakradhar886
Copy link
Copy Markdown
Member

  • Update conda.yaml: python 3.8->3.10, scikit-learn 0.24.2->1.5.1, numpy, scipy, pandas, azureml-mlflow versions aligned with sklearn-1.5
  • Update Environment: base image ubuntu20.04->ubuntu22.04, remove hardcoded version to avoid stale cached environments
  • Update workflow: python-version 3.8->3.10 (3.8 EOL, sklearn-1.5 requires 3.9+)

Root cause: data prep environment (python 3.8, sklearn 0.24.2) was incompatible with curated sklearn-1.5 training environment, causing 502 liveness probe failure on deployment container startup.

Description

Checklist

  • I have read the contribution guidelines.
  • I have coordinated with the docs team (mldocs@microsoft.com) if this PR deletes files or changes any file names or file extensions.
  • Pull request includes test coverage for the included changes.
  • This notebook or file is added to the CODEOWNERS file, pointing to the author or the author's team.

- Update conda.yaml: python 3.8->3.10, scikit-learn 0.24.2->1.5.1,
  numpy, scipy, pandas, azureml-mlflow versions aligned with sklearn-1.5
- Update Environment: base image ubuntu20.04->ubuntu22.04, remove
  hardcoded version to avoid stale cached environments
- Update workflow: python-version 3.8->3.10 (3.8 EOL, sklearn-1.5
  requires 3.9+)

Root cause: data prep environment (python 3.8, sklearn 0.24.2) was
incompatible with curated sklearn-1.5 training environment, causing
502 liveness probe failure on deployment container startup.
@microsoft-github-policy-service
Copy link
Copy Markdown

@Chakradhar886 please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.

@microsoft-github-policy-service agree [company="{your company}"]

Options:

  • (default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
@microsoft-github-policy-service agree
  • (when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.
@microsoft-github-policy-service agree company="Microsoft"
Contributor License Agreement

Contribution License Agreement

This Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”),
and conveys certain license rights to Microsoft Corporation and its affiliates (“Microsoft”) for Your
contributions to Microsoft open source projects. This Agreement is effective as of the latest signature
date below.

  1. Definitions.
    “Code” means the computer software code, whether in human-readable or machine-executable form,
    that is delivered by You to Microsoft under this Agreement.
    “Project” means any of the projects owned or managed by Microsoft and offered under a license
    approved by the Open Source Initiative (www.opensource.org).
    “Submit” is the act of uploading, submitting, transmitting, or distributing code or other content to any
    Project, including but not limited to communication on electronic mailing lists, source code control
    systems, and issue tracking systems that are managed by, or on behalf of, the Project for the purpose of
    discussing and improving that Project, but excluding communication that is conspicuously marked or
    otherwise designated in writing by You as “Not a Submission.”
    “Submission” means the Code and any other copyrightable material Submitted by You, including any
    associated comments and documentation.
  2. Your Submission. You must agree to the terms of this Agreement before making a Submission to any
    Project. This Agreement covers any and all Submissions that You, now or in the future (except as
    described in Section 4 below), Submit to any Project.
  3. Originality of Work. You represent that each of Your Submissions is entirely Your original work.
    Should You wish to Submit materials that are not Your original work, You may Submit them separately
    to the Project if You (a) retain all copyright and license information that was in the materials as You
    received them, (b) in the description accompanying Your Submission, include the phrase “Submission
    containing materials of a third party:” followed by the names of the third party and any licenses or other
    restrictions of which You are aware, and (c) follow any other instructions in the Project’s written
    guidelines concerning Submissions.
  4. Your Employer. References to “employer” in this Agreement include Your employer or anyone else
    for whom You are acting in making Your Submission, e.g. as a contractor, vendor, or agent. If Your
    Submission is made in the course of Your work for an employer or Your employer has intellectual
    property rights in Your Submission by contract or applicable law, You must secure permission from Your
    employer to make the Submission before signing this Agreement. In that case, the term “You” in this
    Agreement will refer to You and the employer collectively. If You change employers in the future and
    desire to Submit additional Submissions for the new employer, then You agree to sign a new Agreement
    and secure permission from the new employer before Submitting those Submissions.
  5. Licenses.
  • Copyright License. You grant Microsoft, and those who receive the Submission directly or
    indirectly from Microsoft, a perpetual, worldwide, non-exclusive, royalty-free, irrevocable license in the
    Submission to reproduce, prepare derivative works of, publicly display, publicly perform, and distribute
    the Submission and such derivative works, and to sublicense any or all of the foregoing rights to third
    parties.
  • Patent License. You grant Microsoft, and those who receive the Submission directly or
    indirectly from Microsoft, a perpetual, worldwide, non-exclusive, royalty-free, irrevocable license under
    Your patent claims that are necessarily infringed by the Submission or the combination of the
    Submission with the Project to which it was Submitted to make, have made, use, offer to sell, sell and
    import or otherwise dispose of the Submission alone or with the Project.
  • Other Rights Reserved. Each party reserves all rights not expressly granted in this Agreement.
    No additional licenses or rights whatsoever (including, without limitation, any implied licenses) are
    granted by implication, exhaustion, estoppel or otherwise.
  1. Representations and Warranties. You represent that You are legally entitled to grant the above
    licenses. You represent that each of Your Submissions is entirely Your original work (except as You may
    have disclosed under Section 3). You represent that You have secured permission from Your employer to
    make the Submission in cases where Your Submission is made in the course of Your work for Your
    employer or Your employer has intellectual property rights in Your Submission by contract or applicable
    law. If You are signing this Agreement on behalf of Your employer, You represent and warrant that You
    have the necessary authority to bind the listed employer to the obligations contained in this Agreement.
    You are not expected to provide support for Your Submission, unless You choose to do so. UNLESS
    REQUIRED BY APPLICABLE LAW OR AGREED TO IN WRITING, AND EXCEPT FOR THE WARRANTIES
    EXPRESSLY STATED IN SECTIONS 3, 4, AND 6, THE SUBMISSION PROVIDED UNDER THIS AGREEMENT IS
    PROVIDED WITHOUT WARRANTY OF ANY KIND, INCLUDING, BUT NOT LIMITED TO, ANY WARRANTY OF
    NONINFRINGEMENT, MERCHANTABILITY, OR FITNESS FOR A PARTICULAR PURPOSE.
  2. Notice to Microsoft. You agree to notify Microsoft in writing of any facts or circumstances of which
    You later become aware that would make Your representations in this Agreement inaccurate in any
    respect.
  3. Information about Submissions. You agree that contributions to Projects and information about
    contributions may be maintained indefinitely and disclosed publicly, including Your name and other
    information that You submit with Your Submission.
  4. Governing Law/Jurisdiction. This Agreement is governed by the laws of the State of Washington, and
    the parties consent to exclusive jurisdiction and venue in the federal courts sitting in King County,
    Washington, unless no federal subject matter jurisdiction exists, in which case the parties consent to
    exclusive jurisdiction and venue in the Superior Court of King County, Washington. The parties waive all
    defenses of lack of personal jurisdiction and forum non-conveniens.
  5. Entire Agreement/Assignment. This Agreement is the entire agreement between the parties, and
    supersedes any and all prior agreements, understandings or communications, written or oral, between
    the parties relating to the subject matter hereof. This Agreement may be assigned by Microsoft.

…ent crash

- Update conda.yaml: python 3.8->3.10, scikit-learn 0.24.2->1.5.1,
  numpy, scipy, pandas, azureml-mlflow versions aligned with sklearn-1.5
- Update Environment: base image ubuntu20.04->ubuntu22.04, remove
  hardcoded version to avoid stale cached environments
- Update workflow: python-version 3.8->3.10 (3.8 EOL, sklearn-1.5
  requires 3.9+)
- Add ml_client.jobs.stream() call after pipeline submission to wait
  for pipeline completion before deploying the model

Root cause: pipeline job was submitted asynchronously but notebook
proceeded to deploy without waiting. The deployment picked up a stale
model from a previous run trained with incompatible sklearn, causing
502 liveness probe failure on the inference container.
- Revert train.py to module-level mlflow (matches working pipeline.ipynb)
- Change train.yml to use custom environment (azureml:aml-scikit-learn@latest)
  instead of curated sklearn-1.5 to ensure consistency between data_prep
  and train pipeline steps
- Remove inference-schema[numpy-support]==1.3.0 (incompatible with
  Python 3.10 / numpy 1.26.4, not needed for training pipeline)
- Add mlflow==2.14.3 pin (matching working azureml-in-a-day tutorial)
- These likely caused conda environment build failure -> train_job crash
Add missing pip packages (psutil, tqdm, ipykernel, matplotlib) that
are present in the working azureml-in-a-day conda.yaml. The environment
build may require these for proper initialization.
The e2e-ml-workflow notebook was submitting the pipeline asynchronously and
immediately proceeding to deployment. This caused the deployment to use a
stale model from a previous run, resulting in a 502 liveness probe failure.

Added ml_client.jobs.stream(pipeline_job.name) to wait for pipeline completion
before deploying the model.
The data_prep_component declared its data input as uri_folder, but the
pipeline passes uri_file (CSV data). Newer AzureML SDK enforces the
declared type, causing args.data to be a directory path instead of
a file path, which makes pd.read_csv(args.data) fail.

Changed to uri_file to match the actual data type being passed,
consistent with the quickstart.ipynb tutorial pattern.
- Added version='1.0.0' to Environment() to ensure a fresh environment
  build with the updated conda.yaml packages, avoiding potential stale
  environment resolution in the shared workspace.
- Reverted data_prep_component input type back to uri_folder (original
  value) since the pipeline was passing before the dep updates.
…sion

- Added select_first_file() to data_prep.py to properly handle the
  uri_folder input type. The component declares data as uri_folder,
  so args.data is a folder path - pd.read_csv needs a file path.
  This matches the pattern already used in train.py.
- Removed explicit version='1.0.0' from Environment() to avoid
  colliding with existing stale environment versions in the shared
  workspace. Uses auto-versioning like the working azureml-in-a-day
  tutorial.
mlflow==2.14.3 imports pkg_resources (from setuptools) at module level.
With pip=24.0 and Python 3.10, setuptools is no longer bundled by
default in conda environments, causing:
  ModuleNotFoundError: No module named 'pkg_resources'
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant