Chat adapter error update (#2471)

* add error emitter to typing indicator

* add proxy in stateful client for typingIndicator

* add test

* Change files

* fix name

* Update @internal-react-composites-7cc319fa-75a7-4732-b1fb-a9425738de8d.json

* update composite test script to build first

* add test to stateful suite

* fix spelling...

* remove auto build

Author: dmceachernmsft

change/@internal-chat-stateful-client-bd3e4081-e838-4f5f-8eed-5d5b00cbce11.json

@@ -0,0 +1,7 @@
+{
+  "type": "patch",
+  "comment": "Fix issue where typingIndicator errors were not being caught by the ChatAdapter.",
+  "packageName": "@internal/chat-stateful-client",
+  "email": "94866715+dmceachernmsft@users.noreply.github.com",
+  "dependentChangeType": "patch"
+}

change/@internal-react-composites-7cc319fa-75a7-4732-b1fb-a9425738de8d.json

@@ -0,0 +1,7 @@
+{
+  "type": "patch",
+  "comment": "Fix issue where typingIndicator errors were not being caught by the ChatAdapter",
+  "packageName": "@internal/react-composites",
+  "email": "94866715+dmceachernmsft@users.noreply.github.com",
+  "dependentChangeType": "patch"
+}

packages/chat-stateful-client/src/StatefulChatThreadClient.test.ts

@@ -317,6 +317,17 @@ describe('stateful chatThreadClient correctly wraps errors', () => {
     );
   });
 
+  test('when sendTypingNotification fails', async () => {
+    const chatThreadClient = createMockChatThreadClient('threadId');
+    chatThreadClient.sendTypingNotification = async (): Promise<boolean> => {
+      throw new Error('injected error');
+    };
+    const client = createMockChatClientWithChatThreadClient(chatThreadClient);
+    await expect(client.getChatThreadClient('threadId').sendTypingNotification()).rejects.toThrow(
+      new ChatError('ChatThreadClient.sendTypingNotification', new Error('injected error'))
+    );
+  });
+
   test('when sendMessage fails', async () => {
     const chatThreadClient = createMockChatThreadClient('threadId');
     chatThreadClient.sendMessage = async (): Promise<any> => {

packages/chat-stateful-client/src/StatefulChatThreadClient.ts

@@ -109,6 +109,14 @@ class ProxyChatThreadClient implements ProxyHandler<ChatThreadClient> {
       case 'listReadReceipts': {
         return createDecoratedListReadReceipts(chatThreadClient, this._context);
       }
+      case 'sendTypingNotification': {
+        return this._context.withAsyncErrorTeedToState(
+          async (...args: Parameters<ChatThreadClient['sendTypingNotification']>) => {
+            return await chatThreadClient.sendTypingNotification(...args);
+          },
+          'ChatThreadClient.sendTypingNotification'
+        );
+      }
       case 'removeParticipant': {
         return this._context.withAsyncErrorTeedToState(
           async (...args: Parameters<ChatThreadClient['removeParticipant']>) => {

packages/react-composites/src/composites/ChatComposite/adapter/AzureCommunicationChatAdapter.test.ts

@@ -111,6 +111,24 @@ describe('Error is reflected in state and events', () => {
     const allLoaded = await adapter.loadPreviousChatMessages(1);
     expect(allLoaded).toBe(true);
   });
+
+  it('when sendTypingNotification fails', async () => {
+    const threadClient = new StubChatThreadClient();
+    threadClient.sendTypingNotification = (): Promise<boolean> => {
+      throw new Error('injected error');
+    };
+    const adapter = await createChatAdapterWithStubs(new StubChatClient(threadClient));
+    const stateListener = new StateChangeListener(adapter);
+    const errorListener = new ErrorListener(adapter);
+
+    await expect(adapter.sendTypingIndicator()).rejects.toThrow();
+
+    expect(stateListener.onChangeCalledCount).toBe(1);
+    const latestError = stateListener.state.latestErrors['ChatThreadClient.sendTypingNotification'];
+    expect(latestError).toBeDefined();
+    expect(errorListener.errors.length).toBe(1);
+    expect(errorListener.errors[0].target).toBe('ChatThreadClient.sendTypingNotification');
+  });
 });
 
 const createChatAdapterWithStubs = async (chatClient: StubChatClient): Promise<ChatAdapter> => {

packages/react-composites/src/composites/ChatComposite/adapter/AzureCommunicationChatAdapter.ts

@@ -228,7 +228,9 @@ export class AzureCommunicationChatAdapter implements ChatAdapter {
   }
 
   async sendTypingIndicator(): Promise<void> {
-    await this.handlers.onTyping();
+    await this.asyncTeeErrorToEventEmitter(async () => {
+      await this.handlers.onTyping();
+    });
   }
 
   async removeParticipant(userId: string): Promise<void> {