Chat adapter error update#2471
Merged
dmceachernmsft merged 13 commits intomainfrom Oct 31, 2022
Merged
Conversation
dmceachernmsft
requested review from
JamesBurnside,
alkwa-msft,
anjulgarg,
carocao-msft and
edwardlee-msft
as code owners
dmceachernmsft
requested review from
PorterNan,
mgamis-msft,
prabhjot-msft and
prprabhu-ms
as code owners
…Azure/communication-ui-library into dmceachernmsft/chatAdapterError
Contributor
Calling bundle size is not changed.
|
Contributor
Chat bundle size is increased❗.
|
Contributor
CallWithChat bundle size is increased❗.
|
Contributor
Contributor
prprabhu-ms
approved these changes
Oct 28, 2022
PorterNan
reviewed
Oct 31, 2022
PorterNan
reviewed
Oct 31, 2022
| case 'listReadReceipts': { | ||
| return createDecoratedListReadReceipts(chatThreadClient, this._context); | ||
| } | ||
| case 'sendTypingNotification': { |
Contributor
There was a problem hiding this comment.
there is a unit test for statefulChatThreadClient:
StatefulCallClient.test.ts in the same folder
And there is a test set named 'errors should be reported correctly from Call when'
Would be nice to add this into the test set
PorterNan
approved these changes
Oct 31, 2022
Contributor
Contributor
carocao-msft
pushed a commit
that referenced
this pull request
Oct 31, 2022
* add error emitter to typing indicator * add proxy in stateful client for typingIndicator * add test * Change files * fix name * Update @internal-react-composites-7cc319fa-75a7-4732-b1fb-a9425738de8d.json * update composite test script to build first * add test to stateful suite * fix spelling... * remove auto build
carocao-msft
added a commit
that referenced
this pull request
Nov 2, 2022
* add drawer to mobile * Change files * add drawer to mobile * Change files * Require webpack 5 in our lib. Add minimum webpack and typescript versions to storybook. Update `html-to-parser` version (#2428) Co-authored-by: Prathmesh Prabhu <82062616+prprabhu-ms@users.noreply.github.com> * Fix `dtmfDialpadPlaceHolderText` spelling and restrict it to beta builds (#2439) * Add troubleshooting guide error bar to call composite config screen (#2433) * add error bar * Change files * pr fix * add drawer to mobile * Add troubleshooting guide error bar to call composite config screen (#2433) * add error bar * Change files * pr fix * add drawer to mobile * Add troubleshooting guide error bar to call composite config screen (#2433) * add error bar * Change files * pr fix * add drawer to mobile * pr fix * pr change * add modal to config screen * pr change * Cheery-pick to main: Stable release branch hotfix: Fix camera turning back on when turned off on connecting screen (#2458) (#2460) * Revert breaking API change in `CallEndedListener` callback (#2464) * Only export `DeclarativeCallAgent` in beta builds (#2469) * Chat adapter error update (#2471) * add error emitter to typing indicator * add proxy in stateful client for typingIndicator * add test * Change files * fix name * Update @internal-react-composites-7cc319fa-75a7-4732-b1fb-a9425738de8d.json * update composite test script to build first * add test to stateful suite * fix spelling... * remove auto build * 1.4.0 pre-release branch (#2432) * pr change * pr fix * Add webpack 5 support for treeshaking (#2448) * Add webpack 5 support for treeshaking * Remove webpack plugin * Use not deprecated api Co-authored-by: Nan Jiang <jinan@microsoft.com> * pr fix * Change files * build fix Co-authored-by: James Burnside <2684369+JamesBurnside@users.noreply.github.com> Co-authored-by: Prathmesh Prabhu <82062616+prprabhu-ms@users.noreply.github.com> Co-authored-by: Donald McEachern <94866715+dmceachernmsft@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Porter Nan <jiangnanhello@live.com> Co-authored-by: Nan Jiang <jinan@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Fixes issue where adapter errors aren't being caught
Why
Issue where
sendTypingIndicatorerrors were not being caught by the adapter.#2425
https://skype.visualstudio.com/SPOOL/_workitems/edit/3026772
How Tested
Added new unit test to validate the error capture.