Add allow access modal to configuration screen #2463
Merged
carocao-msft merged 34 commits intomainfrom Nov 2, 2022
Merged
Conversation
carocao-msft
requested review from
JamesBurnside,
PorterNan,
alkwa-msft,
anjulgarg,
dmceachernmsft,
edwardlee-msft,
mgamis-msft and
prabhjot-msft
as code owners
* add error emitter to typing indicator * add proxy in stateful client for typingIndicator * add test * Change files * fix name * Update @internal-react-composites-7cc319fa-75a7-4732-b1fb-a9425738de8d.json * update composite test script to build first * add test to stateful suite * fix spelling... * remove auto build
* Add webpack 5 support for treeshaking * Remove webpack plugin * Use not deprecated api Co-authored-by: Nan Jiang <jinan@microsoft.com>
Contributor
carocao-msft
changed the base branch from
main
to
alkwa/call-composite-joins-rooms
carocao-msft
changed the base branch from
alkwa/call-composite-joins-rooms
to
main
Contributor
Contributor
Contributor
Contributor
dmceachernmsft
approved these changes
Nov 2, 2022
JamesBurnside
approved these changes
Nov 2, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Add allow access modal to configuration screen
Why
This is part of call readiness feature
How Tested
pr.mov
Also tested by setting callreadinessoptin to false in app.tsx and verified the feature disappears
Accessibility tested