aria label missing in Call composite configuration page#1172
Conversation
alcail
requested review from
JamesBurnside,
PorterNan,
alkwa-msft,
anjulgarg,
mgamis-msft and
prprabhu-ms
as code owners
|
Failed to pass the component examples UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "ui change" label to the PR for updating the snapshot. |
|
Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "ui change" label to the PR for updating the snapshot. |
1 similar comment
|
Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "ui change" label to the PR for updating the snapshot. |
|
Failed to pass the component examples UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "ui change" label to the PR for updating the snapshot. |
|
Failed to pass the Static HTML UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "ui change" label to the PR for updating the snapshot. |
| <Label | ||
| id={'call-composite-local-sound-settings-label'} | ||
| className={mergeStyles(dropDownStyles(theme).label)} | ||
| disabled={!props.microphonePermissionGranted || props.speakers.length === 0} // depends on dropdowns disabled state in the sound settings stack |
There was a problem hiding this comment.
Shouldn't this be &&.
The label should be disabled if both DropDown are disabled.
There was a problem hiding this comment.
why? you can have mic but not speakers, of vise-versa.
And the only condition for "Start" button is if mic permission is granted, so I should not even test the speakers if I really want to follow the "Start" button behaviour.
That's making me realize that I should follow this behaviour LOL
|
Failed to pass the Static HTML UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "ui change" label to the PR for updating the snapshot. |
|
Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "ui change" label to the PR for updating the snapshot. |
|
Failed to pass the component examples UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "ui change" label to the PR for updating the snapshot. |
|
Failed to pass the Static HTML UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "ui change" label to the PR for updating the snapshot. |
|
Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "ui change" label to the PR for updating the snapshot. |
1 similar comment
|
Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "ui change" label to the PR for updating the snapshot. |
3 participants
What
replace mic label by a common label for both mic and speakers dropdown
Why
bug: https://skype.visualstudio.com/SPOOL/_workitems/edit/2565537
How Tested
Ran calling sample locally and checked with Accessibility Insights
Process & policy checklist
Is this a breaking change?