Skip to content

Upgrade communication signaling version to 1.0.0.beta.12 #1352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
anjulgarg merged 7 commits into from
Jan 25, 2022
Merged

Upgrade communication signaling version to 1.0.0.beta.12 #1352

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
1fa4fde
Upgrade @azure/communication-signaling to 1.0.0.beta.12
anjulgarg Jan 24, 2022
8a8d7ae
Change files
anjulgarg Jan 24, 2022
fb6c770
Adding new dep to pnpm-lock
anjulgarg Jan 24, 2022
13e8567
Merge branch 'main' into anjulgarg/2706004-upgrade-communication-sign…
anjulgarg Jan 25, 2022
da0db3b
Merge branch 'main' into anjulgarg/2706004-upgrade-communication-sign…
anjulgarg Jan 25, 2022
ccb4266
Merge branch 'main' into anjulgarg/2706004-upgrade-communication-sign…
anjulgarg Jan 25, 2022
1e63958
Merge branch 'main' into anjulgarg/2706004-upgrade-communication-sign…
anjulgarg Jan 25, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions change/@internal-chat-component-bindings-a9d0bfc1-233e-4a06-81fd-bf95ddbdccb1.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "patch",
"comment": "Upgrade @azure/communication-signaling to 1.0.0.beta.12",
"packageName": "@internal/chat-component-bindings",
"email": "anjulgarg@live.com",
"dependentChangeType": "patch"
}
7 changes: 7 additions & 0 deletions change/@internal-chat-stateful-client-375af1fd-ce2b-4d69-86c5-8637846e6f01.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "patch",
"comment": "Upgrade @azure/communication-signaling to 1.0.0.beta.12",
"packageName": "@internal/chat-stateful-client",
"email": "anjulgarg@live.com",
"dependentChangeType": "patch"
}
7 changes: 7 additions & 0 deletions change/@internal-react-composites-dc5b6810-d1e1-45a6-bd4b-da7cb8861d41.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "patch",
"comment": "Upgrade @azure/communication-signaling to 1.0.0.beta.12",
"packageName": "@internal/react-composites",
"email": "anjulgarg@live.com",
"dependentChangeType": "patch"
}
7 changes: 7 additions & 0 deletions change/@internal-storybook-f824c21d-d4f4-47a3-979c-f2063badf4b9.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "patch",
"comment": "Upgrade @azure/communication-signaling to 1.0.0.beta.12",
"packageName": "@internal/storybook",
"email": "anjulgarg@live.com",
"dependentChangeType": "patch"
}
36 changes: 24 additions & 12 deletions common/config/rush/pnpm-lock.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

36 changes: 24 additions & 12 deletions common/config/rush/variants/stable/pnpm-lock.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion packages/chat-component-bindings/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@
},
"dependencies": {
"@azure/communication-common": "1.0.0",
"@azure/communication-signaling": "1.0.0-beta.5",
"@azure/communication-signaling": "1.0.0-beta.12",
"@azure/core-paging": "~1.1.3",
"@internal/acs-ui-common": "1.0.1-beta.1",
"@internal/chat-stateful-client": "1.0.1-beta.1",
Expand Down
2 changes: 1 addition & 1 deletion packages/chat-stateful-client/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@
"_test:by-flavor": "(if-env COMMUNICATION_REACT_FLAVOR=stable && rushx preprocess || if-env COMMUNICATION_REACT_FLAVOR=beta && echo \"skip preprocess\") && jest"
},
"dependencies": {
"@azure/communication-signaling": "1.0.0-beta.5",
"@azure/communication-signaling": "1.0.0-beta.12",
"@azure/core-paging": "~1.1.3",
"@internal/acs-ui-common": "1.0.1-beta.1",
"events": "~3.3.0",
Expand Down
3 changes: 2 additions & 1 deletion packages/chat-stateful-client/src/EventSubscriber.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,8 @@ export class EventSubscriber {
senderDisplayName: event.senderDisplayName,
sequenceId: '', // Note: there is a bug in chatMessageReceived event that it is missing sequenceId
createdOn: new Date(event.createdOn),
editedOn: 'editedOn' in event ? event.editedOn : undefined
editedOn: 'editedOn' in event ? event.editedOn : undefined,
metadata: event.metadata
});
};

Expand Down
3 changes: 2 additions & 1 deletion packages/chat-stateful-client/src/StatefulChatClient.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,7 +166,8 @@ describe('declarative chatClient subscribe to event properly after startRealtime
sender: { kind: 'communicationUser', communicationUserId: 'sender1' },
senderDisplayName: '',
message: 'message',
recipient: { kind: 'communicationUser', communicationUserId: 'userId1' }
recipient: { kind: 'communicationUser', communicationUserId: 'userId1' },
metadata: {}
};

await client.triggerEvent('chatMessageReceived', event);
Expand Down
2 changes: 1 addition & 1 deletion packages/communication-react/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
"types": "dist/communication-react.d.ts",
"dependencies": {
"@azure/communication-common": "1.0.0",
"@azure/communication-signaling": "1.0.0-beta.5",
"@azure/communication-signaling": "1.0.0-beta.12",
"@azure/core-http": "1.2.4",
"@azure/core-paging": "~1.1.3",
"@fluentui/react": "~8.17.2",
Expand Down
2 changes: 1 addition & 1 deletion packages/react-composites/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@
},
"dependencies": {
"@azure/communication-common": "1.0.0",
"@azure/communication-signaling": "1.0.0-beta.5",
"@azure/communication-signaling": "1.0.0-beta.12",
"@azure/core-http": "1.2.4",
"@azure/core-paging": "~1.1.3",
"@fluentui/react": "~8.17.2",
Expand Down
2 changes: 1 addition & 1 deletion packages/storybook/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
"@azure/communication-common": "1.0.0",
"@azure/communication-identity": "1.0.0",
"@azure/communication-react": "1.0.1-beta.1",
"@azure/communication-signaling": "1.0.0-beta.5",
"@azure/communication-signaling": "1.0.0-beta.12",
"@azure/core-http": "1.2.4",
"@fluentui/react-hooks": "~8.3.8",
"@fluentui/react-icons": "~1.1.137",
Expand Down
2 changes: 1 addition & 1 deletion samples/Chat/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
"@azure/communication-common": "1.0.0",
"@azure/communication-identity": "1.0.0",
"@azure/communication-react": "1.0.1-beta.1",
"@azure/communication-signaling": "1.0.0-beta.5",
"@azure/communication-signaling": "1.0.0-beta.12",
"@azure/core-http": "1.2.4",
"@fluentui/react": "~8.17.2",
"@fluentui/react-icons": "~1.1.137",
Expand Down
⚡