MeetingComposite: Use a SplitButton with device selection dropdown#1392
MeetingComposite: Use a SplitButton with device selection dropdown#1392prprabhu-ms merged 24 commits intomainfrom
MeetingComposite: Use a SplitButton with device selection dropdown#1392Conversation
|
Failed to pass the composite UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "ui change" label to the PR for updating the snapshot. |
|
Failed to pass the composite UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "ui change" label to the PR for updating the snapshot. |
prprabhu-ms
requested review from
JamesBurnside,
PorterNan,
alkwa-msft,
anjulgarg,
carocao-msft,
dmceachernmsft,
edwardlee-msft and
mgamis-msft
as code owners
JamesBurnside
left a comment
JamesBurnside
left a comment
There was a problem hiding this comment.
only concern is with overriding the split etc properties in the btns, otherwise this is great!!
|
Failed to pass the composite UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "ui change" label to the PR for updating the snapshot. |
|
whelp. Need to register an icon in the e2e tests. This looks good in samples, but not e2e tests. |
…b.com/Azure/communication-ui-library into prprabhu/newstyle-buttons-splitbutton
|
Will let this PR in without the fix showing icons in e2e snapshots. We have a bug for that: https://skype.visualstudio.com/SPOOL/_workitems/edit/2707880 Fix is to |
4 participants
What
MicrophoneButton. When set, use aSplitButtonwith a context menu for audio device selection.DevicesButtonfor implementationMicrophoneButtonto return audio device informationMicrophoneButtonstory to showcase the new fields.MicrophoneButtoninMeetingComposite.Why
MeetingCompositeintroduces a new way of selecting devices, butCallCompositewill continue to use a separateDevicesButton. This API extension toMicrophoneButtonallows either button to be used for device controls.How Tested
(Please don't mind the fat buttons. Those will look better once #1388 lands and this is rebased)
Stable build
All new API is introduced conditionally. Stable API is unchanged.