Skip to content

Fix PIPIP overlap in chat pane #1674

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dmceachernmsft merged 10 commits into from
Mar 16, 2022
Merged

Fix PIPIP overlap in chat pane #1674

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
083939e
increase the z-index of the pipip
dmceachernmsft Mar 16, 2022
ea80590
Move zIndex manipulation closer
prprabhu-ms Mar 16, 2022
3a3016c
Change files
dmceachernmsft Mar 16, 2022
c2fa52e
Merge branch 'dmceachernmsft/pipipChatThreadFix' of https://github.co…
dmceachernmsft Mar 16, 2022
721ecf5
Merge branch 'main' into dmceachernmsft/pipipChatThreadFix
dmceachernmsft Mar 16, 2022
171a46b
removed unused import
dmceachernmsft Mar 16, 2022
c8218ec
add missing jsdoc comment
dmceachernmsft Mar 16, 2022
4893f1f
Merge branch 'main' into dmceachernmsft/pipipChatThreadFix
dmceachernmsft Mar 16, 2022
a118730
move getPipStyles to a better file.
dmceachernmsft Mar 16, 2022
ca0579a
Merge branch 'main' into dmceachernmsft/pipipChatThreadFix
dmceachernmsft Mar 16, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/react-composites/src/composites/CallWithChatComposite/ModalLocalAndRemotePIP.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ const modalStyle: IStyleFunctionOrObject<IModalStyleProps, IModalStyles> = {
minWidth: 'min-content',
minHeight: 'min-content',
position: 'absolute',
zIndex: 1,
zIndex: 3, // set the z-index to keep the PIPIP above the other items in the chat and people panes.
Comment thread
prprabhu-ms marked this conversation as resolved.
Outdated
overflow: 'hidden',
// pointer events for root Modal div set to auto to make LocalAndRemotePIP interactive
pointerEvents: 'auto',
Expand Down
⚡