Fix PIPIP overlap in chat pane (#1674)#1680
Merged
dmceachernmsft merged 4 commits intorelease/1.2.0from Mar 17, 2022
Merged
Conversation
* increase the z-index of the pipip * Move zIndex manipulation closer * Change files * removed unused import * add missing jsdoc comment * move getPipStyles to a better file. Co-authored-by: Prathmesh Prabhu <82062616+prprabhu-ms@users.noreply.github.com>
dmceachernmsft
requested review from
JamesBurnside,
PorterNan,
alkwa-msft,
anjulgarg,
carocao-msft,
edwardlee-msft,
mgamis-msft,
prabhjot-msft and
prprabhu-ms
as code owners
Contributor
Contributor
|
Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "ui change" label to the PR for updating the snapshot. |
Contributor
Contributor
Contributor
dmceachernmsft
deleted the
dmceachernmsft/pipipOverlappingChatMessageFixCherry-pick
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Update PIPIP styles with 'relative position' and z-index to match chat thread.
Why
Prevents overlapping the Personas in the chat thread
How Tested
ran and inspected locally.