Skip to content

Dialpad first version #1870

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
carocao-msft merged 17 commits into from
May 11, 2022
Merged

Dialpad first version #1870

Show file tree
Hide file tree
Changes from 9 commits
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
d31e778
dialpad
carocao-msft May 9, 2022
4f2618f
Merge branch 'main' into carocao/dialpad
carocao-msft May 9, 2022
8c40f38
Change files
carocao-msft May 9, 2022
e16146c
Merge branch 'carocao/dialpad' of github.com:Azure/communication-ui-l…
carocao-msft May 9, 2022
ba374b8
dialpad
carocao-msft May 9, 2022
b77f58e
dialpad
carocao-msft May 9, 2022
e81bde0
NA countrycode format
carocao-msft May 9, 2022
e4bec27
PR change
carocao-msft May 10, 2022
d5536e9
pr change
carocao-msft May 10, 2022
24cf79e
pr change
carocao-msft May 10, 2022
4be5111
pr change
carocao-msft May 11, 2022
ef00d08
Merge branch 'main' into carocao/dialpad
carocao-msft May 11, 2022
f037564
pr change
carocao-msft May 11, 2022
cc75bce
Merge branch 'carocao/dialpad' of github.com:Azure/communication-ui-l…
carocao-msft May 11, 2022
f5cc98a
Merge branch 'main' into carocao/dialpad
carocao-msft May 11, 2022
a89deb2
lint
carocao-msft May 11, 2022
517d25b
pull from main
carocao-msft May 11, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions change/@internal-react-components-21e8f907-7e5d-4170-a58b-9a77ffeafb2e.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "prerelease",
"comment": "Created dialpad component",
"packageName": "@internal/react-components",
"email": "carolinecao@microsoft.com",
"dependentChangeType": "patch"
}
7 changes: 7 additions & 0 deletions change/@internal-storybook-dfb20e7a-cdad-416e-85b7-a826207cd287.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "prerelease",
"comment": "created storybook preview for dialpad component",
"packageName": "@internal/storybook",
"email": "carolinecao@microsoft.com",
"dependentChangeType": "patch"
}
46 changes: 46 additions & 0 deletions packages/communication-react/review/communication-react.api.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,7 @@ import { IPersonaStyles } from '@fluentui/react';
import { IRenderFunction } from '@fluentui/react';
import { IStyle } from '@fluentui/react';
import { IStyleFunctionOrObject } from '@fluentui/react';
import { ITextFieldStyles } from '@fluentui/react';
import { LatestMediaDiagnostics } from '@azure/communication-calling';
import { LatestNetworkDiagnostics } from '@azure/communication-calling';
import type { MediaDiagnosticChangedEventArgs } from '@azure/communication-calling';
Expand Down Expand Up @@ -1169,6 +1170,8 @@ export type ComponentProps<Component extends (props: any) => JSX.Element> = Chat
export interface ComponentStrings {
cameraButton: CameraButtonStrings;
devicesButton: DevicesButtonStrings;
// Warning: (ae-incompatible-release-tags) The symbol "dialpad" is marked as @public, but its signature references "DialpadStrings" which is marked as @beta
dialpad: DialpadStrings;
endCallButton: EndCallButtonStrings;
errorBar: ErrorBarStrings;
messageStatusIndicator: MessageStatusIndicatorStrings;
Expand Down Expand Up @@ -1551,6 +1554,49 @@ export interface DiagnosticsCallFeatureState {
network: NetworkDiagnosticsState;
}

// @beta
export const Dialpad: (props: DialpadProps) => JSX.Element;

// @beta
export interface DialpadButtonsType {
// (undocumented)
primaryContent: string;
// (undocumented)
secondaryContent?: string;
}

// @beta
export interface DialpadProps {
// (undocumented)
dialpadButtons?: DialpadButtonsType[][];
// (undocumented)
strings?: DialpadStrings;
// (undocumented)
styles?: Partial<DialpadStyles>;
}

// @beta
export interface DialpadStrings {
// (undocumented)
defaultText: string;
// (undocumented)
errorText: string;
}

// @beta
export interface DialpadStyles {
// (undocumented)
button?: IButtonStyles;
// (undocumented)
digit?: IStyle;
// (undocumented)
root?: IStyle;
// (undocumented)
subDigit?: IStyle;
// (undocumented)
textField?: Partial<ITextFieldStyles>;
}

// @public
export type DisplayNameChangedListener = (event: {
participantId: CommunicationIdentifierKind;
Expand Down
5 changes: 5 additions & 0 deletions packages/communication-react/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,6 +92,7 @@ export {
ControlBar,
ControlBarButton,
DevicesButton,
Dialpad,
EndCallButton,
ErrorBar,
GridLayout,
Expand Down Expand Up @@ -136,6 +137,10 @@ export type {
DevicesButtonProps,
DevicesButtonStrings,
DevicesButtonStyles,
DialpadProps,
DialpadStrings,
DialpadButtonsType,
DialpadStyles,
EndCallButtonProps,
EndCallButtonStrings,
ErrorBarProps,
Expand Down
29 changes: 29 additions & 0 deletions packages/communication-react/stable-review/communication-react.api.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,7 @@ import { IPersonaStyles } from '@fluentui/react';
import { IRenderFunction } from '@fluentui/react';
import { IStyle } from '@fluentui/react';
import { IStyleFunctionOrObject } from '@fluentui/react';
import { ITextFieldStyles } from '@fluentui/react';
import { LatestMediaDiagnostics } from '@azure/communication-calling';
import { LatestNetworkDiagnostics } from '@azure/communication-calling';
import type { MediaDiagnosticChangedEventArgs } from '@azure/communication-calling';
Expand Down Expand Up @@ -1125,6 +1126,7 @@ export type ComponentProps<Component extends (props: any) => JSX.Element> = Chat
export interface ComponentStrings {
cameraButton: CameraButtonStrings;
devicesButton: DevicesButtonStrings;
dialpad: DialpadStrings;
endCallButton: EndCallButtonStrings;
errorBar: ErrorBarStrings;
messageStatusIndicator: MessageStatusIndicatorStrings;
Expand Down Expand Up @@ -1487,6 +1489,33 @@ export interface DiagnosticsCallFeatureState {
network: NetworkDiagnosticsState;
}

// @public
export const Dialpad: (props: DialpadProps) => JSX.Element;
Comment thread
carocao-msft marked this conversation as resolved.
Outdated

// @public
export interface DialpadProps {
// (undocumented)
containerStyles?: IStyle;
// (undocumented)
digitStyles?: IStyle;
// (undocumented)
rowStyles?: IStyle;
// (undocumented)
strings?: DialpadStrings;
// (undocumented)
subStyles?: IStyle;
// (undocumented)
textFieldStyles?: Partial<ITextFieldStyles>;
}

// @public
export interface DialpadStrings {
// (undocumented)
defaultText: string;
// (undocumented)
errorText: string;
}

// @public
export type DisplayNameChangedListener = (event: {
participantId: CommunicationIdentifierKind;
Expand Down
46 changes: 46 additions & 0 deletions packages/react-components/review/react-components.api.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ import { IPersonaStyles } from '@fluentui/react';
import { IRenderFunction } from '@fluentui/react';
import { IStyle } from '@fluentui/react';
import { IStyleFunctionOrObject } from '@fluentui/react';
import { ITextFieldStyles } from '@fluentui/react';
import { MessageStatus } from '@internal/acs-ui-common';
import { PartialTheme } from '@fluentui/react';
import { PersonaPresence } from '@fluentui/react';
Expand Down Expand Up @@ -199,6 +200,8 @@ export interface ComponentLocale {
export interface ComponentStrings {
cameraButton: CameraButtonStrings;
devicesButton: DevicesButtonStrings;
// Warning: (ae-incompatible-release-tags) The symbol "dialpad" is marked as @public, but its signature references "DialpadStrings" which is marked as @beta
dialpad: DialpadStrings;
endCallButton: EndCallButtonStrings;
errorBar: ErrorBarStrings;
messageStatusIndicator: MessageStatusIndicatorStrings;
Expand Down Expand Up @@ -371,6 +374,49 @@ export interface DevicesButtonStyles extends ControlBarButtonStyles {
menuStyles?: Partial<DevicesButtonContextualMenuStyles>;
}

// @beta
export const Dialpad: (props: DialpadProps) => JSX.Element;

// @beta
export interface DialpadButtonsType {
Comment thread
carocao-msft marked this conversation as resolved.
Outdated
// (undocumented)
primaryContent: string;
// (undocumented)
secondaryContent?: string;
}

// @beta
export interface DialpadProps {
// (undocumented)
dialpadButtons?: DialpadButtonsType[][];
// (undocumented)
strings?: DialpadStrings;
// (undocumented)
styles?: Partial<DialpadStyles>;
Comment thread
carocao-msft marked this conversation as resolved.
Outdated
}

// @beta
export interface DialpadStrings {
// (undocumented)
defaultText: string;
// (undocumented)
errorText: string;
}

// @beta
export interface DialpadStyles {
// (undocumented)
button?: IButtonStyles;
// (undocumented)
digit?: IStyle;
// (undocumented)
root?: IStyle;
// (undocumented)
subDigit?: IStyle;
// (undocumented)
textField?: Partial<ITextFieldStyles>;
}

// @internal
export const _DrawerMenu: (props: _DrawerMenuProps) => JSX.Element;

Expand Down
Loading
⚡