-
Notifications
You must be signed in to change notification settings - Fork 78
Incorporate CallPane into Call Composite with functional button for beta #2109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
edwardlee-msft
merged 16 commits into
main
from
elee/Update-call-composite-to-include-participant-pane
Jul 27, 2022
Merged
Changes from 9 commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
5c6e511
Incorporate CallPane into CallComposite for beta
edwardlee-msft 0137b94
Change files
edwardlee-msft 1a2ed80
Merge branch 'main' into elee/Update-call-composite-to-include-partic…
edwardlee-msft f19e0bd
Add ModaLayerHost to display modal remote and local pip in Call Compo…
edwardlee-msft 4f0bd98
Update comments:
edwardlee-msft 7b216aa
Resolve button size difference in stable and beta
edwardlee-msft 084be8d
Merge branch 'main' into elee/Update-call-composite-to-include-partic…
edwardlee-msft afd4241
Conditionally compile imports used only in beta
edwardlee-msft d6f3e3f
Add data-ui-id for e2e tests
edwardlee-msft 8abae16
E2E tests for PeoplePaneContent in CallComposite (#2124)
edwardlee-msft 56739e6
Merge branch 'main' into elee/Update-call-composite-to-include-partic…
edwardlee-msft 82173c9
Update composite automation snapshots
github-actions[bot] 0da589c
Update composite automation snapshots
github-actions[bot] f326994
Update composite automation snapshots
github-actions[bot] 4fc172b
Update composite automation snapshots
github-actions[bot] 2b18810
Update composite automation snapshots
github-actions[bot] File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
7 changes: 7 additions & 0 deletions
7
change/@internal-react-composites-62738b0b-eba8-4fae-aa3f-f834792c5ed3.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| { | ||
| "type": "prerelease", | ||
| "comment": "Incorporate PeoplePaneContent into Call Composite", | ||
| "packageName": "@internal/react-composites", | ||
| "email": "edwardlee@microsoft.com", | ||
| "dependentChangeType": "patch" | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
45 changes: 45 additions & 0 deletions
45
packages/react-composites/src/composites/CallComposite/components/buttons/People.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,45 @@ | ||
| // Copyright (c) Microsoft Corporation. | ||
| // Licensed under the MIT license. | ||
|
|
||
| import React, { useMemo } from 'react'; | ||
| import { ControlBarButton, ControlBarButtonProps, ControlBarButtonStyles, useTheme } from '@internal/react-components'; | ||
| import { concatStyleSets } from '@fluentui/react'; | ||
| import { CallCompositeIcon } from '../../../common/icons'; | ||
| import { controlButtonBaseStyle } from '../../styles/Buttons.styles'; | ||
|
|
||
| const icon = (): JSX.Element => <CallCompositeIcon iconName={'ControlButtonParticipants'} />; | ||
|
|
||
| /** | ||
| * @private | ||
| */ | ||
| /** @beta */ | ||
| export const People = (props: ControlBarButtonProps): JSX.Element => { | ||
| const { strings, onRenderOnIcon, onRenderOffIcon, onClick } = props; | ||
| const theme = useTheme(); | ||
| const styles: ControlBarButtonStyles = useMemo( | ||
| () => | ||
| concatStyleSets( | ||
| { | ||
| rootChecked: { | ||
| background: theme.palette.neutralLight | ||
| } | ||
| }, | ||
| props.styles ?? {}, | ||
| controlButtonBaseStyle | ||
| ), | ||
| [props.styles, theme.palette.neutralLight] | ||
| ); | ||
|
|
||
| return ( | ||
| <ControlBarButton | ||
| {...props} | ||
| data-ui-id="call-composite-participants-button" | ||
| strings={strings} | ||
| labelKey={'peopleButtonLabelKey'} | ||
| onRenderOnIcon={onRenderOnIcon ?? icon} | ||
| onRenderOffIcon={onRenderOffIcon ?? icon} | ||
| onClick={onClick} | ||
| styles={styles} | ||
| /> | ||
| ); | ||
| }; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should one of these tags be for (PSTN-calls)?