-
Notifications
You must be signed in to change notification settings - Fork 78
Match message thread color in composite to composite background #2126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 27 commits
Commits
Show all changes
29 commits
Select commit
Hold shift + click to select a range
66011d9
Add a background color to all composites
anjulgarg 032c15e
Change files
anjulgarg c92d7ff
comment grammar fix
anjulgarg 00113a2
Removing background color override in control bar
anjulgarg 6d1b86a
updating comment
anjulgarg bd6a57c
Change files
anjulgarg c1be5f4
updating comment
anjulgarg a0c4ac0
Update composite automation snapshots
github-actions[bot] 31d5df4
Update composite automation snapshots
github-actions[bot] 765c7a5
Update composite automation snapshots
github-actions[bot] d623b14
Update composite automation snapshots
github-actions[bot] 919137b
Update composite automation snapshots
github-actions[bot] bfed174
Un-memoizing classname
anjulgarg 7f2fe9f
Update composite automation snapshots
github-actions[bot] 6e12049
Merge branch 'main' into anjulgarg/bugfix-2903659-composite-bg
anjulgarg 6dc7c7c
Update composite automation snapshots
github-actions[bot] 0c4f55f
Adding custom background to control bars in call and call withchat
anjulgarg 285f7f7
Merge branch 'main' of https://github.com/Azure/communication-ui-libr…
anjulgarg dc1fe13
Update composite automation snapshots
github-actions[bot] ed0981b
Adding background color to message thread in composite to match compo…
anjulgarg caf5c7e
Merge branch 'main' of https://github.com/Azure/communication-ui-libr…
anjulgarg df8133f
Change files
anjulgarg 32b63d8
Update changelog
anjulgarg 99bcdbf
Merge branch 'main' into anjulgarg/bugfix-2903659-composite-bg
anjulgarg ecdf5d8
Update composite automation snapshots
github-actions[bot] a7f2b55
Update composite automation snapshots
github-actions[bot] f7ab793
Update composite automation snapshots
github-actions[bot] 795b59b
Merge branch 'main' of https://github.com/Azure/communication-ui-libr…
anjulgarg d879e8a
Update composite automation snapshots
github-actions[bot] File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
7 changes: 7 additions & 0 deletions
7
change/@internal-react-composites-cb2a0169-f171-4264-a126-c5bbd66d43b4.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| { | ||
| "type": "patch", | ||
| "comment": "Message thread background color in composites matches composite background color", | ||
| "packageName": "@internal/react-composites", | ||
| "email": "anjulgarg@live.com", | ||
| "dependentChangeType": "patch" | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file modified
BIN
+167 Bytes
(100%)
...eadReceipt.test.ts-snapshots/read-message-tooltip-text-Desktop-Chrome-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need this empty object here incase everything else is undefined? I haven't seen this way of defining the styles on a component.