Add UI test for custom composite call control options by JamesBurnside · Pull Request #2324 · Azure/communication-ui-library

JamesBurnside · 2022-09-09T15:17:55Z

What

Add a UI test for setting specific call and callwithchat composite call control options
Update callwithchat hermetic tests to support qArgs

Why

Missing test area, came across a bug when locally testing: #2325

How Tested

n/a - see updated snapshots

github-actions · 2022-09-09T15:27:59Z

Storybook URL https://60c7ae6891f0e90039d7cd54-vnrkpnmwsk.chromatic.com/

github-actions · 2022-09-09T15:30:43Z

Calling bundle size is not changed.

Current size: 5067802
Base size: 5067802
Diff size: 0

github-actions · 2022-09-09T15:30:44Z

CallWithChat bundle size is not changed.

Current size: 5453303
Base size: 5453303
Diff size: 0

github-actions · 2022-09-09T15:30:46Z

Chat bundle size is not changed.

Current size: 5193386
Base size: 5193386
Diff size: 0

…te-options

github-actions · 2022-09-09T19:19:31Z

Storybook URL https://60c7ae6891f0e90039d7cd54-ewmiccvpwe.chromatic.com/

github-actions · 2022-09-09T19:40:59Z

Storybook URL https://60c7ae6891f0e90039d7cd54-hoalnskzjx.chromatic.com/

github-actions · 2022-09-09T20:05:11Z

Storybook URL https://60c7ae6891f0e90039d7cd54-ygzuzofaub.chromatic.com/

github-actions · 2022-09-09T20:28:56Z

Storybook URL https://60c7ae6891f0e90039d7cd54-jwelkitwnj.chromatic.com/

github-actions · 2022-09-09T20:54:18Z

Storybook URL https://60c7ae6891f0e90039d7cd54-rkpqjvsfmc.chromatic.com/

prabhjot-msft · 2022-09-12T23:29:53Z

+        cameraButton: {
+          disabled: true
+        },
+        microphoneButton: true,


What does microphoneButton: true signify as the microphone is disabled as well in the snapshots

They are simply valid options so including them in the test, we have a bug where setting it to true is causing it to become disabled: #2325

prabhjot-msft · 2022-09-12T23:30:54Z

+          disabled: true
+        },
+        endCallButton: false,
+        microphoneButton: true,


same as above

mgamis-msft · 2022-09-13T21:09:39Z

-                queryArgs.injectCustomButtons
+                queryArgs.customCallCompositeOptions
+                  ? queryArgs.customCallCompositeOptions
+                  : queryArgs.injectCustomButtons


Not part of this PR but can we remove injectCustomButtons query arg. It seems like a less flexible version of customCallCompositeOptions.

We should, but slightly more difficult as it includes a function which doesn't JSON.stringify well (we'd need to add custom logic to handle it)

…te-options

github-actions · 2022-09-14T20:54:08Z

Storybook URL https://60c7ae6891f0e90039d7cd54-uqbavnwnnf.chromatic.com/

* show/hide menu button * Change files * lint fix' * Update composite automation snapshots * fix test * Update composite automation snapshots * Update composite automation snapshots * show elipses when hovered * Update composite automation snapshots * Update composite automation snapshots * change id to classname' * Update composite automation snapshots * Update composite automation snapshots * new changes based on standup discussion * Add UI test for custom composite call control options (#2324) * Update storybook to contain docs on customizing call controls in call composite (#2333) * snapshots * Update packages/react-composites CallComposite browser test snapshots * Update packages/react-composites CallComposite browser test snapshots * test * Update packages/react-composites CallComposite browser test snapshots * Update packages/react-composites CallComposite browser test snapshots * test * test * Update packages/react-composites CallComposite browser test snapshots * Update packages/react-composites CallComposite browser test snapshots * [Call Readiness] Unsupported Browser UI (#2334) * create new view for the composite * Add base component and strings * remove button * create new story files * add story book content and build * fix icons * move styles to own file * add CC for unsupported browser * more CC work * Change files * fix linter errors * make component beta * remove console * fix cc error * make supporting types interfaces * build API * fix cc * rebuild api * fix nits * Small Refactor: move call composite side pane state handling to its own hook (#2342) * Add instructions to update callwithchat hero sample (#2337) * new changes based on standup discussion * Add UI test for custom composite call control options (#2324) * new changes based on standup discussion * Add UI test for custom composite call control options (#2324) * new changes based on standup discussion * new changes based on standup discussion * new changes based on standup discussion * test fix * test fix * Update packages/react-composites CallComposite browser test snapshots * Update packages/react-composites CallComposite browser test snapshots * delete old snapshot' * Update packages/react-composites CallComposite browser test snapshots * test * Update packages/react-composites CallComposite browser test snapshots * Update packages/react-composites CallComposite browser test snapshots Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Anjul Garg <anjulgarg@live.com> Co-authored-by: James Burnside <2684369+JamesBurnside@users.noreply.github.com> Co-authored-by: Donald McEachern <94866715+dmceachernmsft@users.noreply.github.com> Co-authored-by: Prathmesh Prabhu <82062616+prprabhu-ms@users.noreply.github.com>

* error bar * Change files * error bar * error bar * use action * use action * use action * pr change * [Call Readiness] Unsupported Browser UI (#2334) * create new view for the composite * Add base component and strings * remove button * create new story files * add story book content and build * fix icons * move styles to own file * add CC for unsupported browser * more CC work * Change files * fix linter errors * make component beta * remove console * fix cc error * make supporting types interfaces * build API * fix cc * rebuild api * fix nits * Small Refactor: move call composite side pane state handling to its own hook (#2342) * Add instructions to update callwithchat hero sample (#2337) * Show/hide menu button on hover/click/focus (#2319) * show/hide menu button * Change files * lint fix' * Update composite automation snapshots * fix test * Update composite automation snapshots * Update composite automation snapshots * show elipses when hovered * Update composite automation snapshots * Update composite automation snapshots * change id to classname' * Update composite automation snapshots * Update composite automation snapshots * new changes based on standup discussion * Add UI test for custom composite call control options (#2324) * Update storybook to contain docs on customizing call controls in call composite (#2333) * snapshots * Update packages/react-composites CallComposite browser test snapshots * Update packages/react-composites CallComposite browser test snapshots * test * Update packages/react-composites CallComposite browser test snapshots * Update packages/react-composites CallComposite browser test snapshots * test * test * Update packages/react-composites CallComposite browser test snapshots * Update packages/react-composites CallComposite browser test snapshots * [Call Readiness] Unsupported Browser UI (#2334) * create new view for the composite * Add base component and strings * remove button * create new story files * add story book content and build * fix icons * move styles to own file * add CC for unsupported browser * more CC work * Change files * fix linter errors * make component beta * remove console * fix cc error * make supporting types interfaces * build API * fix cc * rebuild api * fix nits * Small Refactor: move call composite side pane state handling to its own hook (#2342) * Add instructions to update callwithchat hero sample (#2337) * new changes based on standup discussion * Add UI test for custom composite call control options (#2324) * new changes based on standup discussion * Add UI test for custom composite call control options (#2324) * new changes based on standup discussion * new changes based on standup discussion * new changes based on standup discussion * test fix * test fix * Update packages/react-composites CallComposite browser test snapshots * Update packages/react-composites CallComposite browser test snapshots * delete old snapshot' * Update packages/react-composites CallComposite browser test snapshots * test * Update packages/react-composites CallComposite browser test snapshots * Update packages/react-composites CallComposite browser test snapshots Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Anjul Garg <anjulgarg@live.com> Co-authored-by: James Burnside <2684369+JamesBurnside@users.noreply.github.com> Co-authored-by: Donald McEachern <94866715+dmceachernmsft@users.noreply.github.com> Co-authored-by: Prathmesh Prabhu <82062616+prprabhu-ms@users.noreply.github.com> * error bar * error bar * build file * Revert "error bar" This reverts commit cc0c577. * fix index Co-authored-by: Donald McEachern <94866715+dmceachernmsft@users.noreply.github.com> Co-authored-by: James Burnside <2684369+JamesBurnside@users.noreply.github.com> Co-authored-by: Prathmesh Prabhu <82062616+prprabhu-ms@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Anjul Garg <anjulgarg@live.com>

JamesBurnside and others added 3 commits September 9, 2022 00:08

Add UI test for custom call composite call control options

60f97dc

Update composite automation snapshots

500caa7

Update composite automation snapshots

f3f5bf0

JamesBurnside added the ui change label Sep 9, 2022

JamesBurnside assigned mgamis-msft Sep 9, 2022

JamesBurnside requested a review from alkwa-msft as a code owner September 9, 2022 15:17

JamesBurnside assigned prabhjot-msft Sep 9, 2022

JamesBurnside requested review from PorterNan, anjulgarg, carocao-msft, dmceachernmsft, edwardlee-msft, mgamis-msft, prabhjot-msft and prprabhu-ms as code owners September 9, 2022 15:17

JamesBurnside added 2 commits September 9, 2022 15:18

Add call with chat tests

db67714

Update to be endcall button as hidden and mic button as true

c78d636

JamesBurnside mentioned this pull request Sep 9, 2022

Fix control bar controls showing as disabled when the button is set to true #2325

Merged

JamesBurnside added 2 commits September 9, 2022 19:14

remove .only

0385da0

Merge branch 'main' into jaburnsi/add-ui-test-for-custom-call-composi…

50c9f71

…te-options

Update composite automation snapshots

3a67c74

Update composite automation snapshots

2e5e099

Update composite automation snapshots

05d1ba4

Update composite automation snapshots

4f66e5e

prabhjot-msft reviewed Sep 12, 2022

View reviewed changes

mgamis-msft reviewed Sep 13, 2022

View reviewed changes

mgamis-msft approved these changes Sep 13, 2022

View reviewed changes

prabhjot-msft approved these changes Sep 14, 2022

View reviewed changes

Merge branch 'main' into jaburnsi/add-ui-test-for-custom-call-composi…

ef30210

…te-options

JamesBurnside enabled auto-merge (squash) September 14, 2022 20:44

JamesBurnside merged commit 8f82209 into main Sep 14, 2022

JamesBurnside deleted the jaburnsi/add-ui-test-for-custom-call-composite-options branch September 14, 2022 21:18

carocao-msft pushed a commit that referenced this pull request Sep 14, 2022

Add UI test for custom composite call control options (#2324)

31060ca

carocao-msft pushed a commit that referenced this pull request Sep 16, 2022

Add UI test for custom composite call control options (#2324)

db07bff

carocao-msft pushed a commit that referenced this pull request Sep 16, 2022

Add UI test for custom composite call control options (#2324)

618c1ef

Conversation

JamesBurnside commented Sep 9, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What

Why

How Tested

Uh oh!

github-actions Bot commented Sep 9, 2022

Uh oh!

github-actions Bot commented Sep 9, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Calling bundle size is not changed.

Uh oh!

github-actions Bot commented Sep 9, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

CallWithChat bundle size is not changed.

Uh oh!

github-actions Bot commented Sep 9, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Chat bundle size is not changed.

Uh oh!

github-actions Bot commented Sep 9, 2022

Uh oh!

github-actions Bot commented Sep 9, 2022

Uh oh!

github-actions Bot commented Sep 9, 2022

Uh oh!

github-actions Bot commented Sep 9, 2022

Uh oh!

github-actions Bot commented Sep 9, 2022

Uh oh!

prabhjot-msft Sep 12, 2022

Choose a reason for hiding this comment

Uh oh!

JamesBurnside Sep 14, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

prabhjot-msft Sep 12, 2022

Choose a reason for hiding this comment

Uh oh!

mgamis-msft Sep 13, 2022

Choose a reason for hiding this comment

Uh oh!

JamesBurnside Sep 14, 2022

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Sep 14, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

JamesBurnside commented Sep 9, 2022 •

edited

Loading

github-actions Bot commented Sep 9, 2022 •

edited

Loading

github-actions Bot commented Sep 9, 2022 •

edited

Loading

github-actions Bot commented Sep 9, 2022 •

edited

Loading

JamesBurnside Sep 14, 2022 •

edited

Loading