Skip to content

Tooltip strings uncapitilized #2350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mgamis-msft merged 4 commits into from
Sep 21, 2022
Merged

Tooltip strings uncapitilized #2350

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e3c233a
Updated tooltip strings to not be title case
mgamis-msft Sep 15, 2022
2a17120
Change files
mgamis-msft Sep 15, 2022
96afb73
Merge branch 'main' into mgamis/tooltip-strings-uncapitilized
dmceachernmsft Sep 20, 2022
230fa13
Merge branch 'main' into mgamis/tooltip-strings-uncapitilized
mgamis-msft Sep 21, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions change/@internal-react-components-469c85c3-3bf7-4cb0-a0c9-ba00cd8bba0f.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "patch",
"comment": "Updated tooltip strings to not be title case",
"packageName": "@internal/react-components",
"email": "miguelgamis@microsoft.com",
"dependentChangeType": "patch"
}
18 changes: 9 additions & 9 deletions packages/react-components/src/localization/locales/en-US/strings.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@
},
"endCallButton": {
"label": "Leave",
"tooltipContent": "Leave Call"
"tooltipContent": "Leave call"
},
"cameraButton": {
"onLabel": "Turn off",
Expand All @@ -49,7 +49,7 @@
"tooltipOffContent": "Turn on camera",
"tooltipVideoLoadingContent": "Video is loading",
"cameraMenuTitle": "Camera",
"cameraMenuTooltip": "Choose Camera",
"cameraMenuTooltip": "Choose camera",
Copy link
Copy Markdown
Member

@dmceachernmsft dmceachernmsft Sep 20, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this something that also needs to be done in the composite strings as well?

Copy link
Copy Markdown
Contributor Author

@mgamis-msft mgamis-msft Sep 21, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. But I did not find any tooltip strings in the composite. So I think we are good :)

"cameraButtonSplitRoleDescription": "Split button",
"onSplitButtonAriaLabel": "Turn off camera and camera options",
"offSplitButtonAriaLabel": "Turn on camera and camera options",
Expand All @@ -63,9 +63,9 @@
"tooltipOnContent": "Mute microphone",
"tooltipOffContent": "Unmute microphone",
"microphoneMenuTitle": "Microphone",
"microphoneMenuTooltip": "Choose Microphone",
"microphoneMenuTooltip": "Choose microphone",
"speakerMenuTitle": "Speaker",
"speakerMenuTooltip": "Choose Speaker",
"speakerMenuTooltip": "Choose speaker",
"microphoneButtonSplitRoleDescription": "Split button",
"onSplitButtonAriaLabel": "Mute microphone and audio options",
"offSplitButtonAriaLabel": "Unmute microphone and audio options",
Expand All @@ -76,17 +76,17 @@
"label": "Devices",
"tooltipContent": "Manage devices",
"cameraMenuTitle": "Camera",
"cameraMenuTooltip": "Choose Camera",
"cameraMenuTooltip": "Choose camera",
"audioDeviceMenuTitle": "Audio Device",
"audioDeviceMenuTooltip": "Choose Audio Device",
"audioDeviceMenuTooltip": "Choose audio device",
"microphoneMenuTitle": "Microphone",
"microphoneMenuTooltip": "Choose Microphone",
"microphoneMenuTooltip": "Choose microphone",
"speakerMenuTitle": "Speaker",
"speakerMenuTooltip": "Choose Speaker"
"speakerMenuTooltip": "Choose speaker"
},
"participantsButton": {
"label": "People",
"tooltipContent": "Show Participants",
"tooltipContent": "Show participants",
"menuHeader": "In this call",
"participantsListButtonLabel": "{numParticipants} people",
"muteAllButtonLabel": "Mute all",
Expand Down
⚡