Call Readiness Test#2466
Merged
carocao-msft merged 31 commits intomainfrom Nov 2, 2022
Merged
Conversation
carocao-msft
requested review from
JamesBurnside,
PorterNan,
alkwa-msft,
anjulgarg,
dmceachernmsft,
edwardlee-msft and
mgamis-msft
as code owners
carocao-msft
added
the
update_snapshots
github-actions
Bot
removed
the
update_snapshots
Contributor
carocao-msft
added
the
update_snapshots
github-actions
Bot
removed
the
update_snapshots
Contributor
dmceachernmsft
approved these changes
Nov 2, 2022
prprabhu-ms
reviewed
Nov 2, 2022
prprabhu-ms
approved these changes
Nov 2, 2022
Contributor
prprabhu-ms
left a comment
prprabhu-ms
left a comment
There was a problem hiding this comment.
LGTM, but please circle back on the landscape view snapshots. I agree that we want the snapshots to look correct for landscape view as well.
edwardlee-msft
approved these changes
Nov 2, 2022
carocao-msft
added
the
update_snapshots
github-actions
Bot
removed
the
update_snapshots
Contributor
Contributor
|
Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot. |
carocao-msft
added
the
update_snapshots
github-actions
Bot
removed
the
update_snapshots
Contributor
Contributor
|
Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot. |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
E2E tests for call readiness