Skip to content

Update calling SDK for unsupportedBrowser (1.9.1-beta.1)#2475

Merged
dmceachernmsft merged 28 commits intomainfrom
dmceachernmsft/updateCallingsdkunsupportedBrowser
Nov 16, 2022
Merged

Update calling SDK for unsupportedBrowser (1.9.1-beta.1)#2475
dmceachernmsft merged 28 commits intomainfrom
dmceachernmsft/updateCallingsdkunsupportedBrowser

Conversation

@dmceachernmsft
Copy link
Copy Markdown
Member

What

Update the Calling SDK to be able to use the getEnvironmentInfo API (will be a beta when this is really ready for review)

Why

Gives access to the getEnvironmentInfo and Volume level from the Calling SDK

https://skype.visualstudio.com/SPOOL/_workitems/edit/2957735

How Tested

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Nov 2, 2022

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Nov 2, 2022

Chat bundle size is increased❗.

  • Current size: 5569597
  • Base size: 5448804
  • Diff size: 120793

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Nov 2, 2022

CallWithChat bundle size is increased❗.

  • Current size: 5851866
  • Base size: 5731073
  • Diff size: 120793

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Nov 2, 2022

Calling bundle size is increased❗.

  • Current size: 5465302
  • Base size: 5344509
  • Diff size: 120793

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Nov 2, 2022

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Nov 4, 2022

@github-actions
Copy link
Copy Markdown
Contributor

Copy link
Copy Markdown
Member

@JamesBurnside JamesBurnside left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sure to update common/config/rush/common-versions.json file also

Comment thread common/config/rush/pnpm-lock.yaml Outdated
@dmceachernmsft dmceachernmsft added the update_snapshots Set this label to request automated update of UI snapshots label Nov 14, 2022
@github-actions github-actions Bot removed the update_snapshots Set this label to request automated update of UI snapshots label Nov 14, 2022
@github-actions
Copy link
Copy Markdown
Contributor

@dmceachernmsft dmceachernmsft changed the base branch from main to dmceachernmsft/updatePackages November 15, 2022 00:08
@github-actions
Copy link
Copy Markdown
Contributor

Base automatically changed from dmceachernmsft/updatePackages to main November 16, 2022 18:22
@dmceachernmsft dmceachernmsft added the update_snapshots Set this label to request automated update of UI snapshots label Nov 16, 2022
@github-actions github-actions Bot removed the update_snapshots Set this label to request automated update of UI snapshots label Nov 16, 2022
@github-actions
Copy link
Copy Markdown
Contributor

@github-actions
Copy link
Copy Markdown
Contributor

Failed to pass the composite UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot.

@github-actions
Copy link
Copy Markdown
Contributor

Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot.

@github-actions
Copy link
Copy Markdown
Contributor

@github-actions
Copy link
Copy Markdown
Contributor

Failed to pass the composite UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot.

@dmceachernmsft dmceachernmsft merged commit a867bc5 into main Nov 16, 2022
@dmceachernmsft dmceachernmsft deleted the dmceachernmsft/updateCallingsdkunsupportedBrowser branch November 16, 2022 19:15
edwardlee-msft added a commit that referenced this pull request Nov 17, 2022
…2475) (#2535)

* Cherry-pick Update calling SDK for unsupportedBrowser (1.9.1-beta.1) (#2475)

* Cherrypick Update small packages #2527

* Update packages/react-composites CallWithChatComposite browser test snapshots

* Update packages/react-composites ChatComposite browser test snapshots

* Update packages/react-composites CallComposite browser test snapshots

Co-authored-by: Donald McEachern <94866715+dmceachernmsft@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants