Add permissions denied SKU to DomainPermissions#2486
Merged
JamesBurnside merged 22 commits intomainfrom Nov 4, 2022
Merged
Conversation
…al continue anyway button
…te-permission-denied-ui
JamesBurnside
requested review from
PorterNan,
carocao-msft,
dmceachernmsft,
edwardlee-msft,
mgamis-msft,
prabhjot-msft and
prprabhu-ms
as code owners
Contributor
Contributor
Calling bundle size is increased❗.
|
Contributor
Chat bundle size is increased❗.
|
Contributor
CallWithChat bundle size is increased❗.
|
…tes' into jaburnsi/update-permission-denied-ui
Contributor
Contributor
carocao-msft
approved these changes
Nov 4, 2022
Contributor
dmceachernmsft
approved these changes
Nov 4, 2022
…tes' into jaburnsi/update-permission-denied-ui
edwardlee-msft
approved these changes
Nov 4, 2022
Contributor
JamesBurnside
force-pushed
the
jaburnsi/domainPermissionsUIUpdates
branch
from
a33e804 to
5c4f9b9
Compare
JamesBurnside
force-pushed
the
jaburnsi/domainPermissionsUIUpdates
branch
from
5c4f9b9 to
18f6929
Compare
…tes' into jaburnsi/update-permission-denied-ui
Contributor
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Note: We have BrowserPermissions dialogs that are similar, convergence between these will happen in a future PR. This PR just adds the new SKU to the domain permissions modal.
Why
Newer call readiness designs, continuation of #2485
How Tested
Added SKU option to storybook:
