Skip to content

Cursor should show at the end when clicking in dialpad textfield #2576

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
carocao-msft merged 5 commits into from
Dec 7, 2022
Merged

Cursor should show at the end when clicking in dialpad textfield #2576

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
a1556d2
move cursor to end
carocao-msft Dec 6, 2022
375b73e
Change files
carocao-msft Dec 6, 2022
0a0e27b
Duplicate change files for beta release
carocao-msft Dec 6, 2022
5c8ac2b
move cursor to end
carocao-msft Dec 6, 2022
b2499dc
Merge branch 'main' into carocao/dialpad
dmceachernmsft Dec 7, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions change-beta/@azure-communication-react-d3be0530-f540-4d98-a572-ddfc67367bbb.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "patch",
"comment": "Move cursor to the end of input when clicking on dialpad text field",
"packageName": "@azure/communication-react",
"email": "carolinecao@microsoft.com",
"dependentChangeType": "patch"
}
7 changes: 7 additions & 0 deletions change/@azure-communication-react-d3be0530-f540-4d98-a572-ddfc67367bbb.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "patch",
"comment": "Move cursor to the end of input when clicking on dialpad text field",
"packageName": "@azure/communication-react",
"email": "carolinecao@microsoft.com",
"dependentChangeType": "patch"
}
9 changes: 9 additions & 0 deletions packages/react-components/src/components/Dialpad/Dialpad.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -267,6 +267,15 @@ const DialpadContainer = (props: {
onChange={(e: any) => {
setText(e.target.value);
}}
// eslint-disable-next-line @typescript-eslint/no-explicit-any
onClick={(e: any) => {
const input = e.target;
const end = input.value.length;

// Move focus to end of input field
input.setSelectionRange(end, end);
input.focus();
Comment thread
carocao-msft marked this conversation as resolved.
}}
placeholder={props.strings.placeholderText}
data-test-id="dialpad-input"
onRenderSuffix={(): JSX.Element => (
Expand Down
⚡