Fix CallWithChat custom button properties#2750
Merged
JamesBurnside merged 14 commits intomainfrom Feb 15, 2023
Merged
Conversation
…ectly, and have strong typing to enforce this
…e json stringified
…//github.com/Azure/communication-ui-library into jaburnsi/fix-callwithchat-overflow-buttons-2
JamesBurnside
requested review from
alkwa-msft,
carocao-msft and
dmceachernmsft
as code owners
JamesBurnside
requested review from
PorterNan,
edwardlee-msft,
mgamis-msft and
prabhjot-msft
as code owners
JamesBurnside
changed the title
Contributor
Contributor
Chat bundle size is not changed.
|
Contributor
Calling bundle size is decreased✅.
|
Contributor
CallWithChat bundle size is increased❗.
|
dmceachernmsft
approved these changes
Feb 14, 2023
Contributor
Contributor
edwardlee-msft
approved these changes
Feb 15, 2023
JamesBurnside
deleted the
jaburnsi/fix-callwithchat-overflow-buttons-2
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Refactor generateCustomDrawerButtons to:
typeof ControlBarButton,_DrawerMenuItemandIContextMenuItem)overflow -> primary -> secondary, toprimary -> secondary -> overflow-- reason being if the button was intended to be primary but had to overflow it has more importance.Why
The buttons are correctly appearing in the overflow menu after #2748 but these properties weren't working:
onClickwas not functioning when button is overflowshowLabelwas being overridden and hence not appliedstyleswere being overriden and hence not appliedHow Tested
Locally checked properties were all working and added a CI e2e test